feat: update save button state for certificate info #957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AfaqShuaib09
reviewed
Apr 1, 2024
src/data/actions/courseInfo.test.js
Outdated
| @@ -224,6 +230,8 @@ describe('courseInfo edit course actions', () => { | |||
| expect(changeMock).toHaveBeenNthCalledWith(8, 'in_year_value.per_lead_international', 20); | |||
| expect(changeMock).toHaveBeenNthCalledWith(9, 'in_year_value.per_click_usa', 25); | |||
| expect(changeMock).toHaveBeenNthCalledWith(10, 'in_year_value.per_click_international', 30); | |||
| expect(changeMock).toHaveBeenNthCalledWith(10, 'additional_metadata.certificate_info.heading', 'Test Certificate'); | |||
| expect(changeMock).toHaveBeenNthCalledWith(10, 'additional_metadata.certificate_info.blurb', 'test blurb'); | |||
There was a problem hiding this comment.
Suggested change
| expect(changeMock).toHaveBeenNthCalledWith(10, 'additional_metadata.certificate_info.blurb', 'test blurb'); | |
| expect(changeMock).toHaveBeenNthCalledWith(12, 'additional_metadata.certificate_info.heading', 'Test Certificate'); |
update the Nth Called value for the rest of them
AfaqShuaib09
reviewed
Apr 1, 2024
src/data/actions/courseInfo.test.js
Outdated
| @@ -224,6 +230,8 @@ describe('courseInfo edit course actions', () => { | |||
| expect(changeMock).toHaveBeenNthCalledWith(8, 'in_year_value.per_lead_international', 20); | |||
| expect(changeMock).toHaveBeenNthCalledWith(9, 'in_year_value.per_click_usa', 25); | |||
| expect(changeMock).toHaveBeenNthCalledWith(10, 'in_year_value.per_click_international', 30); | |||
| expect(changeMock).toHaveBeenNthCalledWith(10, 'additional_metadata.certificate_info.heading', 'Test Certificate'); | |||
There was a problem hiding this comment.
Suggested change
| expect(changeMock).toHaveBeenNthCalledWith(10, 'additional_metadata.certificate_info.heading', 'Test Certificate'); | |
| expect(changeMock).toHaveBeenNthCalledWith(11, 'additional_metadata.certificate_info.heading', 'Test Certificate'); |
AfaqShuaib09
reviewed
Apr 1, 2024
src/data/actions/courseInfo.js
Outdated
| @@ -118,6 +118,12 @@ function updateFormValuesAfterSave(change, currentFormValues, initialValues) { | |||
| per_click_usa: perClickUSA, | |||
| per_click_international: perClicknternational, | |||
| }, | |||
| additional_metadata: { | |||
| certificate_info: { | |||
| heading, | |||
There was a problem hiding this comment.
Make sure to fix indentation issues
uzairr
force-pushed
the
update-save-state-for-cert-info
branch
2 times, most recently
from
72784f6 to
31b34c1
Compare
|
Please fix failing tests. |
uzairr
force-pushed
the
update-save-state-for-cert-info
branch
from
31b34c1 to
3270a95
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #957 +/- ##
==========================================
+ Coverage 67.25% 67.27% +0.02%
==========================================
Files 128 128
Lines 3219 3221 +2
Branches 931 931
==========================================
+ Hits 2165 2167 +2
Misses 1005 1005
Partials 49 49 ☔ View full report in Codecov by Sentry. |
DawoudSheraz
reviewed
Apr 2, 2024
DawoudSheraz
reviewed
Apr 2, 2024
Comment on lines
+70
to
+78
| flip={false} | ||
| icon={ | ||
| Object { | ||
| "icon": Array [ | ||
| 512, | ||
| 448, | ||
| 512, | ||
| Array [], | ||
| "f0c5", | ||
| "M502.6 70.63l-61.25-61.25C435.4 3.371 427.2 0 418.7 0H255.1c-35.35 0-64 28.66-64 64l.0195 256C192 355.4 220.7 384 256 384h192c35.2 0 64-28.8 64-64V93.25C512 84.77 508.6 76.63 502.6 70.63zM464 320c0 8.836-7.164 16-16 16H255.1c-8.838 0-16-7.164-16-16L239.1 64.13c0-8.836 7.164-16 16-16h128L384 96c0 17.67 14.33 32 32 32h47.1V320zM272 448c0 8.836-7.164 16-16 16H63.1c-8.838 0-16-7.164-16-16L47.98 192.1c0-8.836 7.164-16 16-16H160V128H63.99c-35.35 0-64 28.65-64 64l.0098 256C.002 483.3 28.66 512 64 512h192c35.2 0 64-28.8 64-64v-32h-47.1L272 448z", | ||
| "M384 336H192c-8.8 0-16-7.2-16-16V64c0-8.8 7.2-16 16-16l140.1 0L400 115.9V320c0 8.8-7.2 16-16 16zM192 384H384c35.3 0 64-28.7 64-64V115.9c0-12.7-5.1-24.9-14.1-33.9L366.1 14.1c-9-9-21.2-14.1-33.9-14.1H192c-35.3 0-64 28.7-64 64V320c0 35.3 28.7 64 64 64zM64 128c-35.3 0-64 28.7-64 64V448c0 35.3 28.7 64 64 64H256c35.3 0 64-28.7 64-64V416H272v32c0 8.8-7.2 16-16 16H64c-8.8 0-16-7.2-16-16V192c0-8.8 7.2-16 16-16H96V128H64z", |
There was a problem hiding this comment.
why is snapshot update needed? In a previous change #869, this was not needed.
There was a problem hiding this comment.
i think this is because of the icon dependency on external library, it is recently updated by renovate,
https://github.com/openedx/frontend-app-publisher/blob/master/package-lock.json#L18
uzairr
force-pushed
the
update-save-state-for-cert-info
branch
from
3270a95 to
6641628
Compare
DawoudSheraz
approved these changes
Apr 2, 2024
AfaqShuaib09
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the save button state in case of editing the certificate heading or description.
PROD-3419