Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update to the new version of brand-openedx in the new scope. #916

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

feanil
Copy link
Contributor

@feanil feanil commented Oct 19, 2023

Part of openedx/axim-engineering#23

This updates the @edx/brand alias to point to the brand-openedx package at
the openedx scope. This does not impact imports because this package is used
via an alias.

@feanil feanil requested a review from a team October 19, 2023 20:01
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c1696af) 66.97% compared to head (a195628) 66.97%.

❗ Current head a195628 differs from pull request most recent head e24ed0b. Consider uploading reports for the commit e24ed0b to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #916   +/-   ##
=======================================
  Coverage   66.97%   66.97%           
=======================================
  Files         128      128           
  Lines        3201     3201           
  Branches      927      927           
=======================================
  Hits         2144     2144           
  Misses       1008     1008           
  Partials       49       49           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Part of openedx/axim-engineering#23

This updates the `@edx/brand` alias to point to the `brand-openedx` package at
the `openedx` scope. This does not impact imports because this package is used
via an alias.
@feanil feanil force-pushed the feanil/update_brand_dependency branch from a195628 to e24ed0b Compare October 23, 2023 13:25
@brian-smith-tcril brian-smith-tcril merged commit f4ebc8e into master Oct 23, 2023
3 checks passed
@brian-smith-tcril brian-smith-tcril deleted the feanil/update_brand_dependency branch October 23, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants