Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase subsection grades rounding precision #1397

Conversation

Agrendalath
Copy link
Member

We used two decimal digits to match the experience from the edx-platform. However, openedx/edx-platform#27788 increased the precision to reduce the impact of double rounding.

See the details and testing instructions at openedx/edx-platform#27788.

Private-ref: BB-4210

@openedx-webhooks
Copy link

openedx-webhooks commented May 26, 2024

Thanks for the pull request, @Agrendalath!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/committers-frontend-app-learning. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 26, 2024
Copy link

codecov bot commented May 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.78%. Comparing base (b9d1198) to head (0ac36ee).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1397   +/-   ##
=======================================
  Coverage   87.78%   87.78%           
=======================================
  Files         310      310           
  Lines        5320     5320           
  Branches     1350     1316   -34     
=======================================
  Hits         4670     4670           
  Misses        633      633           
  Partials       17       17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@itsjeyd itsjeyd added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label May 31, 2024
@itsjeyd
Copy link

itsjeyd commented Jun 6, 2024

@Agrendalath Thank you for this contribution!

It looks like the older PR that you mentioned in the description (openedx/edx-platform#27788) is tagged for product review. Should we do the same here?

CC @mphilbrick211

@Agrendalath
Copy link
Member Author

@itsjeyd
Copy link

itsjeyd commented Jun 7, 2024

@Agrendalath OK great, I'll add the product review label now.

@itsjeyd itsjeyd added the product review PR requires product review before merging label Jun 7, 2024
@itsjeyd itsjeyd added the product review complete PR has gone through product review label Sep 20, 2024
@itsjeyd
Copy link

itsjeyd commented Sep 20, 2024

@Agrendalath It looks like you got the go-ahead from product!

I updated labels and Contribution board status of this PR and openedx/edx-platform#27788 to reflect that.

Please ping @committers-frontend-app-learning for review when you're done working on the changes and the build is green :)

CC @mphilbrick211

We used two decimal digits to match the experience from the edx-platform.
However, openedx/edx-platform#27788 increased
the precision to reduce the impact of double rounding.
@Agrendalath Agrendalath force-pushed the agrendalath/increase_grading_precision branch from 12fffea to 0ac36ee Compare September 23, 2024 11:51
@Agrendalath Agrendalath marked this pull request as ready for review September 23, 2024 11:52
@Agrendalath Agrendalath requested a review from a team September 23, 2024 11:55
@Agrendalath Agrendalath self-assigned this Sep 23, 2024
@Agrendalath
Copy link
Member Author

@openedx/committers-frontend-app-learning, could you please review and merge this?

@bradenmacdonald bradenmacdonald merged commit e4a0105 into openedx:master Sep 23, 2024
8 checks passed
@bradenmacdonald bradenmacdonald deleted the agrendalath/increase_grading_precision branch September 23, 2024 18:39
Agrendalath added a commit to open-craft/frontend-app-learning that referenced this pull request Sep 24, 2024
We used two decimal digits to match the experience from the edx-platform.
However, openedx/edx-platform#27788 increased
the precision to reduce the impact of double rounding.

(cherry picked from commit e4a0105)
Agrendalath added a commit to open-craft/frontend-app-learning that referenced this pull request Sep 24, 2024
We used two decimal digits to match the experience from the edx-platform.
However, openedx/edx-platform#27788 increased
the precision to reduce the impact of double rounding.

(cherry picked from commit e4a0105)
Agrendalath added a commit to open-craft/frontend-app-learning that referenced this pull request Sep 25, 2024
We used two decimal digits to match the experience from the edx-platform.
However, openedx/edx-platform#27788 increased
the precision to reduce the impact of double rounding.

(cherry picked from commit e4a0105)
Agrendalath added a commit to open-craft/frontend-app-learning that referenced this pull request Sep 25, 2024
We used two decimal digits to match the experience from the edx-platform.
However, openedx/edx-platform#27788 increased
the precision to reduce the impact of double rounding.

(cherry picked from commit e4a0105)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U product review complete PR has gone through product review product review PR requires product review before merging
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants