Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Add from Library buttons (Authoring MFE - Unit Page) #1462

Closed
bradenmacdonald opened this issue Nov 4, 2024 · 7 comments
Closed
Assignees

Comments

@bradenmacdonald
Copy link
Contributor

bradenmacdonald commented Nov 4, 2024

Update the various buttons for adding library content to a unit, in the authoring MFE.

Currently it looks like this:

Screenshot

But it should be more like the legacy unit page:

Screenshot

Changes:

  1. Fix the "Problem Bank" button:
    a. Make sure it works (it adds an itembank component). Currently, nothing happens when it's clicked.
    b. Ensure it is only visible if v2 libraries are enabled.
    c. Use the correct icon (Paragon's casino icon)
    d. Add the "beta" label
  2. Fix the "Library Content" button:
    a. Make sure it works (display a modal to choose multiple items, add them to the course with upstream_ref set - see legacy UI behavior and copy that)
    b. Ensure it is only visible if v2 libraries are enabled.
    c. Use the correct icon (newsstand - may need to add to Paragon)
    d. Add the "beta" label
  3. Fix the "Legacy Library" button:
    a. Ensure it is hidden if v1 libraries are disabled.

Note: 2a is potentially quite a large item so I suggest doing it in its own PR, separate from the other changes. However, don't spend a ton of time on it, as we'll be overhauling the entire workflow in Epic 7.

Note 2: we are not changing the color of the buttons.

@bradenmacdonald
Copy link
Contributor Author

@jmakowski1123 @sdaitzman FYI - please review this new ticket.

@bradenmacdonald bradenmacdonald changed the title Improve Add from Library buttons (Authoring MFE) Improve Add from Library buttons (Authoring MFE - Unit Page) Nov 4, 2024
@navinkarkera navinkarkera self-assigned this Nov 6, 2024
@jmakowski1123
Copy link

cc @GlugovGrGlib for visibility. These are small additions being made to the new unit page MFE.

@jmakowski1123
Copy link

@bradenmacdonald We'd also like to introduce a new auto order to the component block tiles. See below. Could that be part of this story, or should be a separate story?

Text
Video
Problem
Problem bank beta
Library content
Legacy Libraries (if applicable)
Discussion
Open response
Drag and Drop
Advanced

@bradenmacdonald
Copy link
Contributor Author

@jmakowski1123 What do you mean by "auto order"? If it's just a new order that's fixed, we can include the change in this story. But if you mean something more dynamic, let's make a separate story.

@jmakowski1123
Copy link

I just mean a new order that's fixed. That order should be: (based on logic of which blocks are most commonly used and which blocks are closely related)

Text
Video
Problem
Problem bank beta
Library content
Legacy Libraries (if applicable)
Discussion
Open response
Drag and Drop
Advanced

@navinkarkera
Copy link
Contributor

@jmakowski1123 @lizc577 @sdaitzman @marcotuts This is ready for AC testing on the sandbox

@navinkarkera navinkarkera moved this from Backlog to Ready for AC testing in Libraries Overhaul Nov 23, 2024
@sdaitzman
Copy link

Looks good to me!

image

@github-project-automation github-project-automation bot moved this from Ready for AC testing to Done in Libraries Overhaul Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

5 participants