Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable pii_check linting #35775

Open
kdmccormick opened this issue Nov 5, 2024 · 0 comments
Open

Re-enable pii_check linting #35775

kdmccormick opened this issue Nov 5, 2024 · 0 comments

Comments

@kdmccormick
Copy link
Member

kdmccormick commented Nov 5, 2024

The pii_check in edx-platform not running for a long time. We want to re-enable it as part of:

However, running code_annotations with the --lint flag currently raises errors due to some malformed PII annotations. In particular, these annotations from edx-proctoring need to be fixed:

So, in the PR linked above, we have removed the --lint flag from make pii_check. This issue exists as a reminder for us to put the --lint flag back once the edx-proctoring issue, and any other pii linting errors, are resolved.

Please note that this is separate from @bmtcril 's effort to raise the PII annotation threshold, which is checked by nature of us passing the flag --coverage to code_annotations:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant