feat!: removes deprecated v1 certificate behavior #35562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this removes the long-deprecated v1 certificate behavior. This removes the old-style date selection behavior (ie., not a choice between *Immediately upon passing*, *End date of course*, *A date after the course end date*), which is no longer reliably maintained or supported in Studio or Credentials. FIXES: #35399
Cleanup of some blank line issues
removing unused imports
* fixing a test which was replying on implicit behavior in the choices between certificate display behaviors * lint error
justinhynes
reviewed
Oct 1, 2024
|
Assumption: I believe that the Studio frontend has been converted to an MFE -- the frontend-app-authoring MFE. I assume that the V2 functionality has been carried over, and didn't reimplement the v1 vs. v2 functionality. I wonder if we should create another ticket to take a peek to see if any remnants have made it into the MFE? |
justinhynes
reviewed
Oct 1, 2024
code review suggestion was a good one: improve the default case, because the fallback should be None.
justinhynes
approved these changes
Oct 2, 2024
deborahgu
deleted the
dkaplan1/APER-3199_removeENABLE_V2_CERT_DISPLAY_SETTINGS
branch
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this removes the long-deprecated v1 certificate behavior. This removes the old-style date selection behavior (ie., not a choice between Immediately upon passing, End date of course, A date after the course end date), which is no longer reliably maintained or supported in Studio or Credentials.
There were no special concerns raised either for the deprecation ticket or for the corresponding discussion
FIXES: #35399