-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add instructor dashboard integration #35
Conversation
Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #35 +/- ##
==========================================
+ Coverage 90.78% 92.41% +1.63%
==========================================
Files 2 5 +3
Lines 141 224 +83
==========================================
+ Hits 128 207 +79
- Misses 13 17 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@feanil would you like to leave early feedback on the frontend side? |
dae670d
to
5abd8e0
Compare
5f3555a
to
d8e84a0
Compare
3a409ce
to
087a978
Compare
4b4d61c
to
290c8c8
Compare
@farhan Already rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nits, rest all seems good
Good work overall 🌟
chore: upgrade dependencies
refactor: quality fixes fix: turn settings into a package fix: remove edxapp_wrapper fix: correct import module fix: do not show empty values fix: add missing test settings file fix: add missing test settings file fix: include all modules in the package
chore: quality fixes fix: add manifest.in file fix: restore package data fix: use try catch block for edx-platform imports chore: quality changes chore: add import error fix
chore: add pylint disable chore: quality fixes
chore: add comment for inverted index fix: only show feedback on feedback table column fix: round average rating fix: improve column table size
290c8c8
to
b1a6ef0
Compare
@farhan thanks for the review. I've deleted the file, corrected the comment, and added information in the README for the integration |
472bce1
to
b6f743a
Compare
be911e4
to
39d27fd
Compare
39d27fd
to
f710dd0
Compare
f710dd0
to
6a9ad84
Compare
@Ian2012 approved. |
@farhan please squash |
@Ian2012 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
This PR set an instructor dashboard integration with a report of the answers of every student and an aggregate report:
Testing instructions