Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add instructor dashboard integration #35

Merged
merged 8 commits into from
Dec 9, 2023

Conversation

Ian2012
Copy link
Contributor

@Ian2012 Ian2012 commented Nov 1, 2023

Description

This PR set an instructor dashboard integration with a report of the answers of every student and an aggregate report:

Testing instructions

  1. In your environment add the following setting:
      OPEN_EDX_FILTERS_CONFIG = {
        "org.openedx.learning.instructor.dashboard.render.started.v1": {
          "fail_silently": False,
          "pipeline": [
            "feedback.extensions.filters.AddFeedbackTab",
          ]
        },
      }
     FEATURES["ENABLE_FEEDBACK_INSTRUCTOR_VIEW"] = True
  1. In your course add a feedback component.
  2. Go to the course and answer the feedback component as a student or as an instructor.
  3. Go to the instructor dashboard and verify the following table appears with the feedback information: http://local.overhang.io:8000/courses/course-v1:demo+demo+demo/instructor#view-feedback_instructor
    image

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 1, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Nov 1, 2023

Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (bc4ee70) 90.78% compared to head (6a9ad84) 92.41%.

Files Patch % Lines
feedback/extensions/filters.py 94.73% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
+ Coverage   90.78%   92.41%   +1.63%     
==========================================
  Files           2        5       +3     
  Lines         141      224      +83     
==========================================
+ Hits          128      207      +79     
- Misses         13       17       +4     
Flag Coverage Δ
unittests 92.41% <95.18%> (+1.63%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ian2012
Copy link
Contributor Author

Ian2012 commented Nov 1, 2023

@feanil would you like to leave early feedback on the frontend side?

@Ian2012 Ian2012 requested review from feanil and farhan and removed request for feanil November 1, 2023 19:50
@Ian2012 Ian2012 marked this pull request as ready for review November 2, 2023 18:25
@Ian2012 Ian2012 force-pushed the cag/instructor-dashboard branch 2 times, most recently from dae670d to 5abd8e0 Compare November 2, 2023 18:53
@Ian2012 Ian2012 requested a review from feanil November 2, 2023 18:57
.gitignore Outdated Show resolved Hide resolved
feedback/apps.py Outdated Show resolved Hide resolved
feedback/extensions/filters.py Show resolved Hide resolved
feedback/extensions/filters.py Outdated Show resolved Hide resolved
feedback/extensions/filters.py Outdated Show resolved Hide resolved
feedback/extensions/filters.py Outdated Show resolved Hide resolved
feedback/extensions/filters.py Outdated Show resolved Hide resolved
feedback/extensions/filters.py Outdated Show resolved Hide resolved
requirements/base.in Outdated Show resolved Hide resolved
@Ian2012 Ian2012 force-pushed the cag/instructor-dashboard branch 4 times, most recently from 5f3555a to d8e84a0 Compare November 7, 2023 20:37
@Ian2012 Ian2012 force-pushed the cag/instructor-dashboard branch from 3a409ce to 087a978 Compare November 9, 2023 15:08
@mariajgrimaldi mariajgrimaldi self-requested a review November 9, 2023 16:28
feedback/static/html/feedback_instructor.html Outdated Show resolved Hide resolved
feedback/extensions/filters.py Outdated Show resolved Hide resolved
@Ian2012 Ian2012 force-pushed the cag/instructor-dashboard branch 3 times, most recently from 4b4d61c to 290c8c8 Compare December 1, 2023 14:40
@Ian2012
Copy link
Contributor Author

Ian2012 commented Dec 1, 2023

@farhan Already rebased

Copy link
Contributor

@farhan farhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits, rest all seems good
Good work overall 🌟

tox.ini Show resolved Hide resolved
feedback/static/html/feedback_instructor.html Outdated Show resolved Hide resolved
chore: upgrade dependencies
refactor: quality fixes

fix: turn settings into a package

fix: remove edxapp_wrapper

fix: correct import module

fix: do not show empty values

fix: add missing test settings file

fix: add missing test settings file

fix: include all modules in the package
chore: quality fixes

fix: add manifest.in file

fix: restore package data

fix: use try catch block for edx-platform imports

chore: quality changes

chore: add import error fix
chore: add pylint disable

chore: quality fixes
chore: add comment for inverted index

fix: only show feedback on feedback table column

fix: round average rating

fix: improve column table size
@Ian2012 Ian2012 force-pushed the cag/instructor-dashboard branch from 290c8c8 to b1a6ef0 Compare December 4, 2023 15:40
@Ian2012
Copy link
Contributor Author

Ian2012 commented Dec 4, 2023

@farhan thanks for the review. I've deleted the file, corrected the comment, and added information in the README for the integration

@Ian2012 Ian2012 force-pushed the cag/instructor-dashboard branch from 472bce1 to b6f743a Compare December 4, 2023 19:31
README.rst Outdated Show resolved Hide resolved
@Ian2012 Ian2012 force-pushed the cag/instructor-dashboard branch 5 times, most recently from be911e4 to 39d27fd Compare December 5, 2023 16:15
README.rst Show resolved Hide resolved
@Ian2012 Ian2012 force-pushed the cag/instructor-dashboard branch from 39d27fd to f710dd0 Compare December 7, 2023 13:54
@Ian2012 Ian2012 force-pushed the cag/instructor-dashboard branch from f710dd0 to 6a9ad84 Compare December 7, 2023 13:55
@farhan
Copy link
Contributor

farhan commented Dec 8, 2023

@Ian2012 approved.
Are you going to squash the commits or may I squash and merge it?

@Ian2012
Copy link
Contributor Author

Ian2012 commented Dec 8, 2023

@farhan please squash

@farhan farhan merged commit 92d381b into openedx:master Dec 9, 2023
5 checks passed
@openedx-webhooks
Copy link

@Ian2012 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants