Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@openedx-community-bot should merge with original commit message(s) #134

Open
kdmccormick opened this issue Jul 8, 2022 · 4 comments
Open

Comments

@kdmccormick
Copy link
Member

kdmccormick commented Jul 8, 2022

@openedx-community-bot merge was used to merge this PR. The bot use the "Squash & Merge" strategy, dropped Maria's original commit message, and replaced it with the PR description (which included noise from the PR template): openedx/edx-platform@a11ad35

I think it would be better to do either a "Rebase & Merge" or a "Merge with Merge Commit", which would preserve the author's original commit messages and avoid copying in noise from the PR description. We currently lint commit messages, so it would make sense to use them.

@e0d
Copy link
Contributor

e0d commented Jul 11, 2022

You mean strange as potentially outdated or something else? Based on the description I was expecting a bug in the bot or a compromise.

@kdmccormick
Copy link
Member Author

Sorry, I should have been more specific. What I find strange is that it does a squash+merge, throws out the existing commit message(s), and uses the PR description as the commit message instead. This leads to a very awkwardly long commit message, often including noise from the PR template (like the one linked).

Since we are already linting individual commit messages, I think we should instead just do a rebase+merge or a standard merge, which would preserve the author's original commit messages.

@e0d
Copy link
Contributor

e0d commented Jul 11, 2022

Ah, I clicked on the second link and was lost. Thanks.

@kdmccormick kdmccormick changed the title @openedx-community-bot merge generates long, strange commit messages @openedx-community-bot should use original commit message(s), not PR description Jul 11, 2022
@kdmccormick kdmccormick changed the title @openedx-community-bot should use original commit message(s), not PR description @openedx-community-bot should merge with original commit message(s) Jul 11, 2022
@kdmccormick
Copy link
Member Author

Np. I rewrote the issue title and description to be more self-evident.

@kdmccormick kdmccormick transferred this issue from openedx/axim-engineering May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

2 participants