-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace ccp-
teams with committers-
teams
#132
Comments
@kdmccormick what wouldl you say the priority of this issue is? |
Low urgency, medium-high importance |
Agreed. I wonder if there's a way (label? new column on board?) that we could add these to that are like, "if you're on-call and it's a light week, please take one of these tasks" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Context
We have two types of teams for giving Coding CCs write access to repos:
ccp-$USERNAME
teams andcommitters-$TOPIC
teams. This wiki page explains the difference.Why do we have both types in the first place?
Well, generally, we don't want to give CCs write access directly on any repos. It makes the program harder to audit, because we don't know what access is CC access on what access is special/legacy/accidental. So, we started with the
ccp-$USERNAME
teams because there was only a small number of CCs, and having a 1:1 user-team mapping was straightforward.As the number of CCs grew, some of them gained write access to whole sets of repos (i.e., "all analytics" and "all MFEs"). It got harder to manage individual repos for individual users. It also got ambiguous whether, for instance, a CC with access to "all MFEs" should automatically gain access to new MFEs--to that question, we decided "yes", as long as their CC nomination thread made that clear.
So, we started grouping repos together with teams. The first teams like this were were
frontend-all
,frontend-mfes
, andcc-analytics
. Eventually, we decided to standardize on thecommitters-*
name for all these sort of teams, so those teams are nowcommitters-frontend
,committers-frontend-apps
, andcommitters-analytics
, respectively. For CCs who have access to a single repo rather than a repo group, we figured that we could just have some one-off teams likecommitters-edx-platform
.We should finish switching from
ccp-*
teams tocommitters-*
teams. The only reason we haven't is that it's one of those high-importance-but-low-urgency things.Tasks
Go to the CC access wiki page. Also open up the list of committers- teams.
Look for logical groupings of repos that appear multiple times on the wiki page. Create these groupings as new
committers-
teams if they don't already exist.Then, for every CC:
ccp-
team.committers-
teams as appropriate.committers-
teams, create new repo-specificcommitters-
teams. For example, if some CC has one-off write access toedx-organizations
, create a newcommitters-edx-organizations
team with write access, and add them.fixme-$username
so we know to come back to it.General notes:
The text was updated successfully, but these errors were encountered: