Skip to content
This repository has been archived by the owner on Jul 18, 2024. It is now read-only.

fix: font styling and small ux bugs #373

Merged
merged 4 commits into from
Nov 3, 2023

Conversation

KristinAoki
Copy link
Contributor

JIRA Ticket: TNL-11149

  • Not enough spacing above and below heading
  • Add space below alert component
  • Fields should be spaced farther apart
  • Error text should match Figma
  • Remove “x” from error text
  • Cancel and create buttons should be right aligned
  • Fields and buttons should be inside of a card
  • Menu should say “No results found” instead of “No options”

Before
Screenshot 2023-11-02 at 5 02 14 PM

After
Screenshot 2023-11-02 at 5 01 10 PM

@KristinAoki KristinAoki requested a review from a team as a code owner November 2, 2023 21:03
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (fbdc822) 52.39% compared to head (e41267a) 52.41%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #373      +/-   ##
==========================================
+ Coverage   52.39%   52.41%   +0.02%     
==========================================
  Files          75       75              
  Lines        1983     1986       +3     
  Branches      359      359              
==========================================
+ Hits         1039     1041       +2     
- Misses        911      912       +1     
  Partials       33       33              
Files Coverage Δ
src/library-authoring/common/FormGroup.jsx 94.11% <100.00%> (ø)
...ary-authoring/create-library/LibraryCreatePage.jsx 79.68% <100.00%> (+1.56%) ⬆️
src/library-authoring/create-library/messages.js 100.00% <ø> (ø)
src/library-authoring/create-library/data/slice.js 14.28% <0.00%> (-1.72%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KristinAoki KristinAoki merged commit 28af666 into master Nov 3, 2023
5 checks passed
@KristinAoki KristinAoki deleted the KristinAoki/fix-library-create-page-ux-bugs branch November 3, 2023 20:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants