-
Notifications
You must be signed in to change notification settings - Fork 25
feat: upgrade mathjax from v2 to v3 #352
feat: upgrade mathjax from v2 to v3 #352
Conversation
Thanks for the pull request, @navinkarkera! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #352 +/- ##
=======================================
Coverage 52.41% 52.41%
=======================================
Files 75 75
Lines 1986 1986
Branches 359 359
=======================================
Hits 1041 1041
Misses 912 912
Partials 33 33 ☔ View full report in Codecov by Sentry. |
Hey @navinkarkera, is this PR ready for review? |
@itsjeyd Yes. |
@jristau1984 This PR is ready for engineering review by TNL. |
@navinkarkera Kindly add "jira:2U" label to this, if you have access. cc: @itsjeyd just in case Navin didn't have the access on this repo. |
I've created issue TNL-11195 in the private 2U Jira. |
Hey @jristau1984, do you have any updates about when we can expect TNL to review this PR? |
@jristau1984 Thanks for the update.
To understand better, is that work happening via another PR? Or would @navinkarkera be expected to address @wittjeff's concerns in the context of this PR (and if so where can he find the feedback)? |
@itsjeyd We have feedback from Jeff in edx-platform PR: openedx/edx-platform#33555 |
@navinkarkera OK I see. I'll keep this PR in the Blocked status, then. Let me know when you're ready to resume the work here. CC @jristau1984 |
Hey @navinkarkera, do you have any updates on when this PR might get unblocked? |
@navinkarkera Friendly ping about my comment above. |
@itsjeyd Apologies for missing your ping. This is blocked on openedx/edx-platform#33555 and we don't have a go ahead from 2U yet. Once course outline MFE project is completed, we might be able to get this across if 2U agrees. |
@navinkarkera Sounds good, thanks for the update! |
Hey folks, we are planning to deprecate |
@bradenmacdonald Makes sense, I'll close the PR. |
@navinkarkera Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
See openedx/edx-platform#33555 for details.