Skip to content
This repository has been archived by the owner on Jul 18, 2024. It is now read-only.

feat: update footer and header #329

Merged
merged 6 commits into from
Oct 4, 2023

Conversation

KristinAoki
Copy link
Contributor

JIRA Ticket: TNL-10751

  • The library-authoring header matches the header in course-authoring (non-xblock-editor pages) in style
  • We want the Library authoring header to look like the course authoring does.
  • We should make it easy for changes to the studio header to be reflected in any learning contexts. We should make a single source of truth for “studio headers.“
  • child components can be passed in to the shared component, injecting a different menu or other feature.
    • If possible frontend-component-header should be the place to make more flexible.

This PR removed the header and footer in this repo and replaces them with the ones from frontend-components-footer and frontend-components-header

Testing
NOTE: The "Import" page before this change did not properly handle the header. The fix for that issue should be separate task to resolve.

  1. on home page and create page, header should only have studio icon and user menu
  2. on all other screens, the dropdowns should be as follows
    • Settings
      • Details
      • User Access
      • Import

@KristinAoki KristinAoki requested a review from a team as a code owner October 3, 2023 16:43
@KristinAoki
Copy link
Contributor Author

This PR is dependent on #328. The test need to be fixed and merged into this PR.

@KristinAoki KristinAoki added the Content Libraries This PR is related to V2 content Libraries work label Oct 3, 2023
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (73214c6) 51.83% compared to head (230c282) 51.75%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #329      +/-   ##
==========================================
- Coverage   51.83%   51.75%   -0.08%     
==========================================
  Files          75       74       -1     
  Lines        1966     1961       -5     
  Branches      355      353       -2     
==========================================
- Hits         1019     1015       -4     
+ Misses        914      913       -1     
  Partials       33       33              
Files Coverage Δ
src/index.jsx 0.00% <ø> (ø)
...-authoring/author-library/LibraryAuthoringPage.jsx 81.59% <ø> (-0.50%) ⬇️
...ring/studio-header-wrapper/StudioHeaderWrapper.jsx 33.33% <0.00%> (+3.33%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KristinAoki KristinAoki merged commit 58f9325 into master Oct 4, 2023
3 of 5 checks passed
@KristinAoki KristinAoki deleted the KristinAoki/update-footer-and-header branch October 4, 2023 14:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Content Libraries This PR is related to V2 content Libraries work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants