Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change in the manner 'zs' is being computed for 1D cases: Intentional or bug? #223

Open
niketagrawal opened this issue Aug 20, 2024 · 1 comment
Labels

Comments

@niketagrawal
Copy link
Collaborator

Error description

Tests fail from the commit b63a8f0 on wards because the array values of 'zs' computed by the code for 1D cases is not the same as the reference it's being compared against.

Root cause

There are changes to avalanching.py and bed.py in the commit b63a8f0 that could be the reason for this.

How to reproduce the issue?

This error can't be reproduced in the main branch because of the presence of another issue #221. A pull request has already been created to fix it. Untill the pull request is merged, you can add the fix locally in your branch and run the tests again to reproduce the issue.

Fix

Are the code changes in the commit b63a8f0 that changes the way 'zs' is computed for 1D cases intentional?
If yes, then the netcdf file used as a reference output in the tests for the 1D cases must be replaced with a netcdf generated with the new changes. Otherwise, the changes must be reverted.

@Sierd
Copy link
Collaborator

Sierd commented Aug 21, 2024

This is related to issue #178

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants