-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RHOAIENG-1154]: Apply modal to alert user error #3512
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2dc38bb
to
d33ca1c
Compare
Would there be a way to detect specifically that the user's session timed out to show the new modal? I feel like it may be slightly misleading because it looks like the code is a catch all, but the message is specific for session expiration? Unless that was the idea, it also doesn't seem that straightfoward to figure out a expired session |
I agree, we should look to identify the exact error response that comes from an expired session to show this modal otherwise we show the old error or update it with some other text if it's not related to expired session. |
Thanks @jenny-s51. The implementation looks good to me. |
Towards https://issues.redhat.com/browse/RHOAIENG-1154.
Description
Before:
After:
How Has This Been Tested?
Edit "--cookie-expire=23h0m0s" in the Dashboard deployment to a lower value (you should also scale down to 0 the rhods operator pod).
Test Impact
Needs info - no existing tests and no updates to the back end in this PR.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main