Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove JUPYTER_IMAGE env variable from notebook container #3407

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DaoDaoNoCode
Copy link
Member

@DaoDaoNoCode DaoDaoNoCode commented Oct 30, 2024

JIRA: RHOAIENG-13602

Description

Simply remove the env variable from the codebase as mentioned.

How Has This Been Tested?

Try to create a workbench, and make sure it can successfully run.

Test Impact

N/A, just modified the mock data based on the change.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link
Contributor

openshift-ci bot commented Oct 30, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mturley for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@23c82ac). Learn more about missing BASE report.
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3407   +/-   ##
=======================================
  Coverage        ?   85.89%           
=======================================
  Files           ?     1338           
  Lines           ?    30127           
  Branches        ?     8274           
=======================================
  Hits            ?    25877           
  Misses          ?     4250           
  Partials        ?        0           
Files with missing lines Coverage Δ
frontend/src/api/k8s/notebooks.ts 96.87% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23c82ac...220c6ad. Read the comment docs.

@andrewballantyne
Copy link
Member

andrewballantyne commented Oct 31, 2024

/hold

IDE conversations are happening

@openshift-ci openshift-ci bot added the do-not-merge/hold This PR is hold for some reason label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold This PR is hold for some reason
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants