Skip to content

Commit

Permalink
[RHOAIENG-11895] fix(odh-nbc): put a newline between certs in case in…
Browse files Browse the repository at this point in the history
…put is missing a newline (#411)

In case that the source of the certificates doesn't contain newline,
this will assure that at least one new line is between the concatenated
certificates. In case that the new line in the source is present
already, then there will be two new lines now, but it shouldn't be a
problem as it shouldn't break anything for us. This fixes [1].

* [1] https://issues.redhat.com/browse/RHOAIENG-11895
  • Loading branch information
jstourac authored Oct 17, 2024
1 parent c3d9c8b commit 648689f
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ func (r *OpenshiftNotebookReconciler) CreateNotebookCertConfigMap(notebook *nbv1
Labels: map[string]string{"opendatahub.io/managed-by": "workbenches"},
},
Data: map[string]string{
"ca-bundle.crt": string(bytes.Join(rootCertPool, []byte{})),
"ca-bundle.crt": string(bytes.Join(rootCertPool, []byte("\n"))),
},
}

Expand Down

0 comments on commit 648689f

Please sign in to comment.