Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from kserve:master #460

Open
wants to merge 39 commits into
base: master
Choose a base branch
from
Open

Conversation

pull[bot]
Copy link

@pull pull bot commented Dec 23, 2024

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

greenmoon55 and others added 12 commits December 17, 2024 17:51
* another squash

Signed-off-by: Jin Dong <[email protected]>

* Add JobTTLSecondsAfterFinished option

Signed-off-by: Jin Dong <[email protected]>

* Update config

Signed-off-by: Jin Dong <[email protected]>

* Use labels to filter jobs instead of deleting old jobs

Signed-off-by: Jin Dong <[email protected]>

* Add log in test

Signed-off-by: Jin Dong <[email protected]>

* Fix test and helm chart

Signed-off-by: Jin Dong <[email protected]>

* Create a seperate file system utils file

Signed-off-by: Jin Dong <[email protected]>

* Add comments

Signed-off-by: Jin Dong <[email protected]>

* Fix status update bug

Signed-off-by: Jin Dong <[email protected]>

---------

Signed-off-by: Jin Dong <[email protected]>
* Allow multiple node groups in the model cache CR

Signed-off-by: Jin Dong <[email protected]>

* Fix test

---------

Signed-off-by: Jin Dong <[email protected]>
* Clean up jobs

Signed-off-by: Jin Dong <[email protected]>

* fix lint

Signed-off-by: Jin Dong <[email protected]>

* Fix lint

Signed-off-by: Jin Dong <[email protected]>

* Fix deletion propagation policy

Signed-off-by: Jin Dong <[email protected]>

* Update test

Signed-off-by: Jin Dong <[email protected]>

---------

Signed-off-by: Jin Dong <[email protected]>
* Add NodeGroup Name Into PVC Name

Signed-off-by: Gavin Li <[email protected]>

* Add comment to fix multiple node group

Signed-off-by: Dan Sun <[email protected]>

* fix openvino dependency

Signed-off-by: Dan Sun <[email protected]>

---------

Signed-off-by: Gavin Li <[email protected]>
Signed-off-by: Dan Sun <[email protected]>
Co-authored-by: Dan Sun <[email protected]>
* Make reconcilation configurable

Signed-off-by: Jin Dong <[email protected]>

* Fix codegen

Signed-off-by: Jin Dong <[email protected]>

* Remove a redudant space

Signed-off-by: Jin Dong <[email protected]>

* Rename config

Signed-off-by: Jin Dong <[email protected]>

* Fix lint

Signed-off-by: Jin Dong <[email protected]>

---------

Signed-off-by: Jin Dong <[email protected]>
Co-authored-by: Dan Sun <[email protected]>
Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
Co-authored-by: Dan Sun <[email protected]>
… metrics bind port and address in helm chart (#4127)

Signed-off-by: Max Howell <[email protected]>
Co-authored-by: Dan Sun <[email protected]>
* Fix EOF error

Signed-off-by: Jonas Bruns <[email protected]>
Signed-off-by: jonas <[email protected]>

* fix error

Signed-off-by: Jonas-Bruns <[email protected]>
Signed-off-by: jonas <[email protected]>

* rename error to ioErr

Signed-off-by: Jonas-Bruns <[email protected]>
Signed-off-by: jonas <[email protected]>

* use errors.Is

Signed-off-by: Jonas-Bruns <[email protected]>
Signed-off-by: jonas <[email protected]>

---------

Signed-off-by: Jonas Bruns <[email protected]>
Signed-off-by: jonas <[email protected]>
Signed-off-by: Jonas-Bruns <[email protected]>
Co-authored-by: Dan Sun <[email protected]>
@pull pull bot added ⤵️ pull merge-conflict Resolve conflicts manually labels Dec 23, 2024
@openshift-ci openshift-ci bot requested review from Jooho and mwaykole December 23, 2024 20:54
Copy link

openshift-ci bot commented Dec 23, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pull[bot]
Once this PR has been reviewed and has the lgtm label, please assign jooho for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented Dec 23, 2024

Hi @pull[bot]. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

* squash commits

Signed-off-by: Jin Dong <[email protected]>

* localmodel agent -> localmodelnode agent

Signed-off-by: Jin Dong <[email protected]>

* Revert change

Signed-off-by: Jin Dong <[email protected]>

---------

Signed-off-by: Jin Dong <[email protected]>
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pull pull bot removed the needs-rebase label Dec 24, 2024
* Fix model server fails to gracefully shutdown

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Update unit tests

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

---------

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
Co-authored-by: Dan Sun <[email protected]>
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@spolti
Copy link
Member

spolti commented Jan 13, 2025

I think we already did this sync: #459

@Jooho
Copy link

Jooho commented Jan 13, 2025

@spolti we missed the last commit (kserve#4148) is it ok to sync this commit next time?

@spolti
Copy link
Member

spolti commented Jan 13, 2025

it is probably better to do another manual sync, or wait the next automated sync do.

@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pull pull bot removed the needs-rebase label Jan 15, 2025
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

FabianScheidt and others added 2 commits January 16, 2025 01:23
* Add boilerplate setup for embeddings api

Signed-off-by: Fabian Scheidt <[email protected]>

* Integrate call to model with embedding request

Signed-off-by: Fabian Scheidt <[email protected]>

* Adjust error responses to be consistent with openai

Signed-off-by: Fabian Scheidt <[email protected]>

* Adjust doc strings to match implementation

Signed-off-by: Fabian Scheidt <[email protected]>

* Update openai input validation to use pydantic

Signed-off-by: Fabian Scheidt <[email protected]>

* Refactor embedding object type

Signed-off-by: Fabian Scheidt <[email protected]>

* Add e2e test for OpenAI embedding endpoint

Signed-off-by: Fabian Scheidt <[email protected]>

* Add unit test for OpenAI embeddings

Signed-off-by: Fabian Scheidt <[email protected]>

---------

Signed-off-by: Fabian Scheidt <[email protected]>
Signed-off-by: Matt Gottlieb <[email protected]>
Co-authored-by: Sivanantham <[email protected]>
@pull pull bot removed the needs-rebase label Jan 16, 2025
Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pull pull bot removed the needs-rebase label Jan 19, 2025
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pull pull bot removed the needs-rebase label Jan 21, 2025
Signed-off-by: jooho lee <[email protected]>
Co-authored-by: Sivanantham <[email protected]>
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: New/Backlog
Development

Successfully merging this pull request may close these issues.