Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Snowflake adapter warnings + add more debug logs #107

Merged
merged 8 commits into from
Sep 9, 2024

Conversation

ValeriyWorld
Copy link
Contributor

@ValeriyWorld ValeriyWorld commented Sep 3, 2024

Warning fixes:

  1. Dependency warning related to snowflake-connector-python package.
  2. Pydantic warning related to Pipe class - it had attribute schema, the same name was used in parent class BaseModel that had method with the same name (it is deprecated though, but still not deleted).

Debug logging enhancement:

  1. Added logger.debug() messages in the mapping functions, which are useful to understand exactly where the collector crashed.
    image
    Error case:
    image
  2. Due to avoid logging duplication (current mapping logic have some nesting logic) - changed properties to the methods decorated with @ttl_cache.

Tests updates:

  1. Updated tests with new adapter and client realisation + added a few pipes to the test.
  2. Added Snowflake tests to our run-tests workflow.

@ValeriyWorld ValeriyWorld self-assigned this Sep 3, 2024
@github-actions github-actions bot added the bug Something isn't working label Sep 3, 2024
@ValeriyWorld ValeriyWorld added chore and removed bug Something isn't working labels Sep 3, 2024
@github-actions github-actions bot added the bug Something isn't working label Sep 4, 2024
@ValeriyWorld ValeriyWorld merged commit 90b447b into main Sep 9, 2024
2 checks passed
@ValeriyWorld ValeriyWorld deleted the add_debug_logging_for_snowflake branch September 9, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants