Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

As a user I want to select a template to issue a certified copy with #7727

Draft
wants to merge 13 commits into
base: develop
Choose a base branch
from
Draft

As a user I want to select a template to issue a certified copy with #7727

wants to merge 13 commits into from
+865 −830

Conversation

tareq89
Copy link
Collaborator

@tareq89 tareq89 commented Oct 4, 2024

@tareq89 tareq89 force-pushed the ocrvs-7584 branch 2 times, most recently from 30246fb to 2762681 Compare October 7, 2024 05:59
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 7, 2024

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

@tareq89 tareq89 self-assigned this Oct 7, 2024
@ocrvs-bot
Copy link
Collaborator

Your environment is deployed to https://ocrvs-7584.opencrvs.dev

@tareq89
update config package to get certificates config from country config
71fc15b
@tareq89
getting certificates config data from config package in client instea…
3f2cd14 
…d of svgcode
@tareq89
changing actions and reducers to accomodate new certificate config ch…
96fd29e 
…anges
@tareq89
certificate template selection is required for collectors to proceed …
df2e976 
…to ReviewCertificate before print in advance
@tareq89
certificate collection removed via migration script
5b66e48
@tareq89
select certificate template label added
1076878
@tareq89
fixed different routes to accomodate certTemplateId
33ddc73
@tareq89
fixing test
4821efe
@tareq89
added missing variable
9e52409
@tareq89
payment and verify-collector test fixed
bbca65e
@tareq89
VerifyCollector, ReviewCertificate and Payment test cases adjusted fo…
f2835ac 
…r certified copies changes
@tareq89
CollectorForm test fixed for certified copies
b0b234b
@tareq89
refactor test code and lint issues
ede9e9c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rikukissa rikukissa Awaiting requested review from rikukissa

@euanmillar euanmillar Awaiting requested review from euanmillar

@Zangetsu101 Zangetsu101 Awaiting requested review from Zangetsu101

@Nil20 Nil20 Awaiting requested review from Nil20

@jamil314 jamil314 Awaiting requested review from jamil314

At least 1 approving review is required to merge this pull request.

Assignees

@tareq89 tareq89

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tareq89 @ocrvs-bot