Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cross-compiled binaries to releases #332

Open
cyphar opened this issue Jun 24, 2020 · 3 comments
Open

add cross-compiled binaries to releases #332

cyphar opened this issue Jun 24, 2020 · 3 comments
Milestone

Comments

@cyphar
Copy link
Member

cyphar commented Jun 24, 2020

We need a make cross and we should cross-compile for releases.

@cyphar cyphar added this to the 0.5.0 milestone Jun 24, 2020
@thesayyn
Copy link

thesayyn commented Jan 4, 2022

hey, @cyphar would you accept a PR for this? I believe it would be easier for me if I do this with goreleaser but I am not sure what your take would be on that.

@cyphar
Copy link
Member Author

cyphar commented Jan 4, 2022

For CI? That would probably be okay, though I suspect that it might be better to take the changes made to release.sh in github.com/opencontainers/runc -- I made quite a few updates which make my particular release workflow (build, sign locally using my smart card PGP key, upload) easier.

@thesayyn
Copy link

thesayyn commented Jan 4, 2022

hmm, do you think it is worth creating this maintenance burden in this repository as well? I am happy to go that road but bash scripts are hard to maintain.

goreleaser supports singing via pgp (see: https://goreleaser.com/customization/sign/). we could possibly make it the default pipeline for releases.

wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants