Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc.NewClient breaks sysrib #433

Open
wenovus opened this issue Jun 12, 2024 · 0 comments
Open

grpc.NewClient breaks sysrib #433

wenovus opened this issue Jun 12, 2024 · 0 comments

Comments

@wenovus
Copy link
Contributor

wenovus commented Jun 12, 2024

This breaks TestRoutePropagation in bgp/tests/local_tests

diff --git a/gribi/gribi.go b/gribi/gribi.go
index edf5803..d86ed3e 100644
--- a/gribi/gribi.go
+++ b/gribi/gribi.go
@@ -74,7 +74,7 @@ func New(s *grpc.Server, gClient gpb.GNMIClient, target string, root *oc.Root, s
 // - root, if specified, will be used to populate connected routes into the RIB
 // manager. Note this is intended to be used for unit/standalone device testing.
 func createGRIBIServer(gClient gpb.GNMIClient, target string, root *oc.Root, sysribAddr string) (*server.Server, error) {
-       gzebraConn, err := grpc.NewClient(sysribAddr, grpc.WithTransportCredentials(insecure.NewCredentials()))
+       gzebraConn, err := grpc.Dial(sysribAddr, grpc.WithTransportCredentials(insecure.NewCredentials()))
        if err != nil {
                return nil, fmt.Errorf("cannot dial to sysrib, %v", err)
        }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant