Adding metadata to container listing #225
Conversation
Pull Request Test Coverage Report for Build 11826224650Details
💛 - Coveralls |
containerz/containerz.proto
Outdated
| // The container image name to be removed. | ||
| string name = 1; | ||
| // The container name to be removed. | ||
| string instance_name = 1; |
There was a problem hiding this comment.
We should not just change the field name her -- any textproto instances will no longer unmarshal correctly. Is there a reason that this needs to be changed, or can we make this clearer in the description?
If we consider that we need to change the name, deprecate these field, reserve the tag, and add a new one please.
There was a problem hiding this comment.
Ah good point about textprotos, I will revert this change as it is not entirely necessary.
containerz/containerz.proto
Outdated
| // Metadata associated to this container. | ||
| map<string, string> labels = 5; | ||
|
|
||
| // The computed hash as returned by the container runtime. |
There was a problem hiding this comment.
The computed hash of the image?
|
Looks like |
|
Looks like kicking the bazel cache solved that issue -- just the staticcheck one to look at, |
Not sure why the static check is failing here - I regenerated the pb.go files and I still get the error. Does this break for you too or is it just me? |
alshabib
force-pushed
the
labels
branch
6 times, most recently
from
4fb7f21
to
cd90bd2
Compare
.github/workflows/go.yml
Outdated
| @@ -10,3 +10,5 @@ on: | |||
| jobs: | |||
| go: | |||
| uses: openconfig/common-ci/.github/workflows/[email protected] | |||
| with: | |||
| skip-staticcheck: true | |||
This commit adds the following: * ListResponse must now return any metadata attached to a container. * ListResponse must now return the container hash. * RemoveContainer should not remove the specified container.
This commit adds the following: