fix/separate api primitives #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files |
|
fixing the |
|
looks like i need to fix the |
mimir-d
force-pushed
the
fix/separate_api_primitives
branch
from
82b8dd6
to
4c539af
Compare
njordr
approved these changes
Oct 8, 2024
- this refactoring is in preparation for the next steps (commits on this branch) - smaller files makes the scope of the objects easier to reason about, grouping them by ocptv topic Signed-off-by: mimir-d <[email protected]>
- `objects.rs` was a mix of unrelated items, move them to separate modules for easier maintainability Signed-off-by: mimir-d <[email protected]>
- previously all log and error outputs needed to know where theyre being called from; this is an antipattern and leaks impl detail - move this context to the proper spaces (in StartedTestRun, StartedTestStep) - this commit changes semantics of the `to_artifact` a bit, but this will be cleared in the next commits which refactor the emitter Signed-off-by: mimir-d <[email protected]>
Signed-off-by: mimir-d <[email protected]>
- reasoning: this spec file will be used in multiple modules (serialized in ::output but deserialize in possibly ::parse) - remove the `Spec` suffix from the objects now, since that's clear from the module name Signed-off-by: mimir-d <[email protected]>
mimir-d
force-pushed
the
fix/separate_api_primitives
branch
from
4c539af
to
4987393
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
split runner.rs into smaller files
grouping them by ocptv topic
objects.rswas a mix of unrelated items, move them to separatemodules for easier maintainability
remove the leaky ArtifactContext
called from; this is an antipattern and leaks impl detail
StartedTestStep)