Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo: Mics -> Misc #34

Merged
merged 1 commit into from
Feb 15, 2018
Merged

Fix typo: Mics -> Misc #34

merged 1 commit into from
Feb 15, 2018

Conversation

hkdobrev
Copy link
Contributor

Misc is short for miscellaneous.

Misc is short for miscellaneous.
@waldyrious
Copy link
Member

Thanks! Great attention to detail 👍

While we're at it, what do you think about using a clearer term altogether? The term was introduced by @nobodxbodon in #27. I wonder if he explicitly chose to use different patterns for different companies -- cf. Gratipay/Counchbase ("All products"), Dreamwidth/GitLab ("Dreamwidth"/"GitLab"), and Dangerous Prototypes ("Projects"), for example.

Would it make more sense to use the same terms uniformly, say "All products" and "Various products" (implying that some of their products are not open source)? Or should we simply replace the "Misc" ones with the clearer "Various products" phrasing, ignoring the other outliers mentioned above?

@hkdobrev
Copy link
Contributor Author

I would just choose 1-2 awesome products to list there as per:

However, a further change like that is more suitable for a separate PR as there could be more feedback and review comments than for a typo :)

@waldyrious
Copy link
Member

Indeed. And about replacing the "Misc" entries? That feels reasonable in scope to me. (I could make the change if you prefer, just looking to hear your thoughts.)

@waldyrious
Copy link
Member

I'll take it from your silence that you'd prefer me to do it, which is fine :) I'll merge and make the changes myself. Thanks again for the contribution!

@waldyrious waldyrious merged commit 911f4ac into opencompany:master Feb 15, 2018
@hkdobrev hkdobrev deleted the patch-1 branch February 15, 2018 22:50
@hkdobrev
Copy link
Contributor Author

Hey, sorry! Just I'm not really sure how to change and this has been sitting in my quite full inbox.

@waldyrious
Copy link
Member

Don't worry, I understand. I have quite a bit of those in my own backburner ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants