-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 2024 NB districts #396
base: master
Are you sure you want to change the base?
Conversation
I have some concerns about continuing to use the numbered districts for these as their identity seems to be more linked to the name than the district number:
However, changing that might be a larger change since that would affect the IDs for all Canadian province districts, so I'd be comfortable with moving forward with this one and revising how these districts are handled in a separate future PR. @jpmckinney can you take a look at this one? I think you have more expertise on Canadian identifiers. |
Names are pretty aligned.
|
Same approach as #306 but with 2024 data this time