Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server Control - Virtual Media #7

Closed
4 tasks
derick-montague opened this issue Mar 30, 2020 · 6 comments
Closed
4 tasks

Server Control - Virtual Media #7

derick-montague opened this issue Mar 30, 2020 · 6 comments
Assignees
@matijas-1987
Labels
help wanted Extra attention is needed

Comments

@derick-montague
Copy link
Contributor

derick-montague commented Mar 30, 2020 •
edited
Loading

Overview

Recreate page in Vue.js

AngularJS Reference

Controllers

Tasks

  • Add route and all route meta data
  • Create page using page components
  • Determine if new components or layout required and verify with design
  • Include language translation
@derick-montague derick-montague added the help wanted Extra attention is needed label Mar 30, 2020
@derick-montague derick-montague assigned erasad22 and unassigned erasad22 Jul 8, 2020
@openbmc openbmc deleted a comment from erasad22 Jul 8, 2020
@derick-montague derick-montague mentioned this issue Jul 9, 2020
Closed
4 tasks
@derick-montague
Copy link
Contributor Author

derick-montague commented Jul 9, 2020 •
edited
Loading

@matijas-1987 are you interested in workin on this story also?

@matijas-1987
Copy link
Contributor

@derick-montague this issue will be made by Asad but you can assign to me.

@matijas-1987
Copy link
Contributor

Mock-up:

vm

@chineweff
Copy link

I got errors when using virtual media.
a

This error messages were from
https://github.com/openbmc/phosphor-webui/blob/master/app/server-control/controllers/virtual-media-controller.js

Does anyone have any ideas?

@derick-montague
Copy link
Contributor Author

I got errors when using virtual media.

It looks like you opened an issue in the correct repository already, openbmc/phosphor-webui#116. This feature has not been developed in the new UI framework.

bradbishop pushed a commit that referenced this issue Aug 28, 2020
@matijas-1987 @derick-montague
Add VirtualMedia page
7510046 
More info: #7

Signed-off-by: Mateusz Gapski <[email protected]>
Change-Id: I68f2074e77301c68c425f1e661988c751224b713
@derick-montague
Copy link
Contributor Author

Gerrit review: https://gerrit.openbmc-project.xyz/c/openbmc/webui-vue/+/35396

rfrandse pushed a commit to ibm-openbmc/webui-vue that referenced this issue Jun 30, 2022
@matijas-1987 @rfrandse
Add VirtualMedia page
88126be 
More info: openbmc#7

Signed-off-by: Mateusz Gapski <[email protected]>
Change-Id: I68f2074e77301c68c425f1e661988c751224b713
rfrandse referenced this issue in ibm-openbmc/webui-vue Jun 30, 2022
@dixsie @rfrandse
Move sensors to use sensor collection schema (#7)
fad8a1b 
Before to get all the Sensors 3 of a chassis,
3 calls were made:
/redfish/v1/Chassis/{chassis}/Power
/redfish/v1/Chassis/{chassis}/Thermal
/redfish/v1/Chassis/{chassis}/Sensors

With this change:
https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/40169
All that is needed is a call to /redfish/v1/Chassis/{chassis}/Sensors

Note: The threshold property is optional on some sensors,
Optional chaining operator (?.) is used to return undefined
if a property does not exist.

Signed-off-by: Dixsie Wolmers <[email protected]>
rfrandse referenced this issue in ibm-openbmc/webui-vue Jul 28, 2022
@dixsie @derick-montague
Move sensors to use sensor collection schema (#7)
22ecf43 
Before to get all the Sensors 3 of a chassis,
3 calls were made:
/redfish/v1/Chassis/{chassis}/Power
/redfish/v1/Chassis/{chassis}/Thermal
/redfish/v1/Chassis/{chassis}/Sensors

With this change:
https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/40169
All that is needed is a call to /redfish/v1/Chassis/{chassis}/Sensors

Note: The threshold property is optional on some sensors,
Optional chaining operator (?.) is used to return undefined
if a property does not exist.

Signed-off-by: Dixsie Wolmers <[email protected]>
rfrandse referenced this issue in ibm-openbmc/webui-vue Jul 28, 2022
@dixsie @rfrandse
Move sensors to use sensor collection schema (#7)
ba9eeda 
Before to get all the Sensors 3 of a chassis,
3 calls were made:
/redfish/v1/Chassis/{chassis}/Power
/redfish/v1/Chassis/{chassis}/Thermal
/redfish/v1/Chassis/{chassis}/Sensors

With this change:
https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/40169
All that is needed is a call to /redfish/v1/Chassis/{chassis}/Sensors

Note: The threshold property is optional on some sensors,
Optional chaining operator (?.) is used to return undefined
if a property does not exist.

Signed-off-by: Dixsie Wolmers <[email protected]>
rfrandse referenced this issue in ibm-openbmc/webui-vue Jul 28, 2022
@dixsie @rfrandse
Move sensors to use sensor collection schema (#7)
95d6a29 
Before to get all the Sensors 3 of a chassis,
3 calls were made:
/redfish/v1/Chassis/{chassis}/Power
/redfish/v1/Chassis/{chassis}/Thermal
/redfish/v1/Chassis/{chassis}/Sensors

With this change:
https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/40169
All that is needed is a call to /redfish/v1/Chassis/{chassis}/Sensors

Note: The threshold property is optional on some sensors,
Optional chaining operator (?.) is used to return undefined
if a property does not exist.

Signed-off-by: Dixsie Wolmers <[email protected]>
rfrandse referenced this issue in ibm-openbmc/webui-vue Jul 28, 2022
@dixsie @rfrandse
Move sensors to use sensor collection schema (#7)
2990da9 
Before to get all the Sensors 3 of a chassis,
3 calls were made:
/redfish/v1/Chassis/{chassis}/Power
/redfish/v1/Chassis/{chassis}/Thermal
/redfish/v1/Chassis/{chassis}/Sensors

With this change:
https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/40169
All that is needed is a call to /redfish/v1/Chassis/{chassis}/Sensors

Note: The threshold property is optional on some sensors,
Optional chaining operator (?.) is used to return undefined
if a property does not exist.

Signed-off-by: Dixsie Wolmers <[email protected]>
rfrandse referenced this issue in ibm-openbmc/webui-vue Jul 28, 2022
@dixsie @rfrandse
Move sensors to use sensor collection schema (#7)
ca27b63 
Before to get all the Sensors 3 of a chassis,
3 calls were made:
/redfish/v1/Chassis/{chassis}/Power
/redfish/v1/Chassis/{chassis}/Thermal
/redfish/v1/Chassis/{chassis}/Sensors

With this change:
https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/40169
All that is needed is a call to /redfish/v1/Chassis/{chassis}/Sensors

Note: The threshold property is optional on some sensors,
Optional chaining operator (?.) is used to return undefined
if a property does not exist.

Signed-off-by: Dixsie Wolmers <[email protected]>
rfrandse referenced this issue in ibm-openbmc/webui-vue Jul 28, 2022
@dixsie @rfrandse
Move sensors to use sensor collection schema (#7)
c224cbe 
Before to get all the Sensors 3 of a chassis,
3 calls were made:
/redfish/v1/Chassis/{chassis}/Power
/redfish/v1/Chassis/{chassis}/Thermal
/redfish/v1/Chassis/{chassis}/Sensors

With this change:
https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/40169
All that is needed is a call to /redfish/v1/Chassis/{chassis}/Sensors

Note: The threshold property is optional on some sensors,
Optional chaining operator (?.) is used to return undefined
if a property does not exist.

Signed-off-by: Dixsie Wolmers <[email protected]>
rfrandse referenced this issue in ibm-openbmc/webui-vue Jul 28, 2022
@dixsie @rfrandse
Move sensors to use sensor collection schema (#7)
4fa3190 
Before to get all the Sensors 3 of a chassis,
3 calls were made:
/redfish/v1/Chassis/{chassis}/Power
/redfish/v1/Chassis/{chassis}/Thermal
/redfish/v1/Chassis/{chassis}/Sensors

With this change:
https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/40169
All that is needed is a call to /redfish/v1/Chassis/{chassis}/Sensors

Note: The threshold property is optional on some sensors,
Optional chaining operator (?.) is used to return undefined
if a property does not exist.

Signed-off-by: Dixsie Wolmers <[email protected]>
rfrandse referenced this issue in ibm-openbmc/webui-vue Jul 28, 2022
@dixsie
Move sensors to use sensor collection schema (#7)
b49347a 
Before to get all the Sensors 3 of a chassis,
3 calls were made:
/redfish/v1/Chassis/{chassis}/Power
/redfish/v1/Chassis/{chassis}/Thermal
/redfish/v1/Chassis/{chassis}/Sensors

With this change:
https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/40169
All that is needed is a call to /redfish/v1/Chassis/{chassis}/Sensors

Note: The threshold property is optional on some sensors,
Optional chaining operator (?.) is used to return undefined
if a property does not exist.

Signed-off-by: Dixsie Wolmers <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matijas-1987 matijas-1987

Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@derick-montague @yoshiemuranaka @erasad22 @chineweff @matijas-1987