You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Should we use property " isCeiling " instead of property "Class" to specify if this stepwise controller supports ceiling feature?
The property “isCeiling” had been described in phosphor-pid-control configure.md before.
In my understanding, “Class” aims to describe the thermal type of the inputs. For example: temperature, power reading, margin and so on.
The text was updated successfully, but these errors were encountered:
I would like to say that the "Ceiling" should be a feature category instead of a sub-type of controller.
A controller with "Ceiling" feature enablement means its output is the max RPM of a zone it contribute to, but it still can be a margin controller at the same time while its inputs are provided by margin sensors. Same for power/powersum controller as well
Then this "Ceiling" feature can be applied to PID controller as well if needed.
I have a little question about an old commit https://gerrit.openbmc.org/c/openbmc/phosphor-pid-control/+/18650
Should we use property " isCeiling " instead of property "Class" to specify if this stepwise controller supports ceiling feature?
The property “isCeiling” had been described in phosphor-pid-control configure.md before.
In my understanding, “Class” aims to describe the thermal type of the inputs. For example: temperature, power reading, margin and so on.
The text was updated successfully, but these errors were encountered: