Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we use property "isCeiling" to specify zone ceiling support instead of "Class"? #37

Open
blackcatevil opened this issue May 12, 2023 · 1 comment

Comments

@blackcatevil
Copy link

I have a little question about an old commit https://gerrit.openbmc.org/c/openbmc/phosphor-pid-control/+/18650

Should we use property " isCeiling " instead of property "Class" to specify if this stepwise controller supports ceiling feature?
The property “isCeiling” had been described in phosphor-pid-control configure.md before.

In my understanding, “Class” aims to describe the thermal type of the inputs. For example: temperature, power reading, margin and so on.

@blackcatevil
Copy link
Author

I would like to say that the "Ceiling" should be a feature category instead of a sub-type of controller.
A controller with "Ceiling" feature enablement means its output is the max RPM of a zone it contribute to, but it still can be a margin controller at the same time while its inputs are provided by margin sensors. Same for power/powersum controller as well
Then this "Ceiling" feature can be applied to PID controller as well if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant