Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crashed when trying to set VLAN id from IPMI command if DHCP is enabled #67

Open
Lin-TommySC opened this issue Sep 15, 2023 · 2 comments
Open

Crashed when trying to set VLAN id from IPMI command if DHCP is enabled #67

Lin-TommySC opened this issue Sep 15, 2023 · 2 comments

Comments

@Lin-TommySC
Copy link

The issue is triggered from this line due to AddressOrigin was not Static:

phosphor-networkd/src/ipaddress.cpp

Line 99 in 5c1e160

elog<NotAllowed>(Reason("Not allowed to delete a non-static address"));

Because phosphor-ipmi-host was deleting all channel objects in line below before creating a VLAN:

https://github.com/openbmc/phosphor-host-ipmid/blob/1b42a9c58f4bb6fc6c4f306e42c0544018064892/transporthandler.cpp#L652C37-L652C37
@raviteja-b
Copy link
Contributor

Can you please provide more details ?
does host-ipmid crashed?
this needs to be handled in ipmid

@Lin-TommySC
Copy link
Author

Can you please provide more details ? does host-ipmid crashed? this needs to be handled in ipmid

Yes, ipmid did crash.

eddiejames pushed a commit to eddiejames/phosphor-networkd that referenced this issue Mar 1, 2024
@asmithakarun @geissonator
Change SLAAC to IPv6SLAAC as per bios enum (openbmc#67)
8fa2a6d 
* Change SLAAC to IPv6SLAAC as per bios enum

The "method" attribute of the bios table had the below
values:
"IPv6Static", "IPv6DHCP", "SLAAC"

There is a recent change that changes "SLAAC" to "IPv6SLAAC".
This commit has changes with respect to the above change.

Tested By:

busctl set-property xyz.openbmc_project.Network.Hypervisor \
/xyz/openbmc_project/network/hypervisor/eth1 \
xyz.openbmc_project.Network.EthernetInterface DHCPEnabled s \
"xyz.openbmc_project.Network.EthernetInterface.DHCPConf.v6stateless"

When the above value is set, the dbus origin is changed to "SLAAC"
and bios table is updated to "IPv6SLAAC"

Change-Id: I619c80b4e25d4a5a8fb7766adcc1191de42b2ffd
Signed-off-by: Asmitha Karunanithi <[email protected]>

* Add dependency on pldm service for hypervisor app

The hypervisor app depends on the bios service currently,
that comes up with the bios table. But it is pldm that
populates the bios table values.

There are cases, where hypervisor app comes up first before
pldm populates the bios table, causing the app to have default values
(0.0.0.0 ip) in the dbus even when vmi ip has been configured.

This commit adds a dependency on pldm service for the
hypervisor app to start.

Tested By:
* Rebooted the bmc - and checked if hypervisor dbus has the vmi ip
  that is configured
* Code updated the bmc to observe the same behaviour as above

Change-Id: I1ba3c54c0eb24ebe7c5fab52ef80a47bd9d57c82
Signed-off-by: Asmitha Karunanithi <[email protected]>

* code-format: fix up downstream clang issues

1050 branch didn't have CI running so some issues got in. Enable CI and
fix issues.

Signed-off-by: Andrew Geissler <[email protected]>

* Fix CI failure for a unit test case

This commit resolves CI failure for dhcpEnabled test case

Change-Id: Ifcb90fc077eba9e44b394f95325e11e22d79322b
Signed-off-by: Asmitha Karunanithi <[email protected]>

---------

Signed-off-by: Asmitha Karunanithi <[email protected]>
Signed-off-by: Andrew Geissler <[email protected]>
Co-authored-by: Andrew Geissler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@raviteja-b @Lin-TommySC