Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IP configuration is not persistent on Disabling Interface and enabling back. #55

Open
swe12345 opened this issue Oct 11, 2022 · 6 comments

Comments

@swe12345
Copy link

Problem:
IP configuration is not persistent on Disabling Interface and enabling it back.

Steps to recreate:

  1. Settings the interface as false using the curl command
    curl -k -H "X-Auth-Token: $bmc_token" -D get.txt -X PATCH -d '{"InterfaceEnabled":false}' https://$bmc/redfish/v1/Managers/bmc/EthernetInterfaces/eth0

2.Now check the configuration- it is lost- expected
3. Now Enable the interface back using curl commands
curl -k -H "X-Auth-Token: $bmc_token" -D get.txt -X PATCH -d '{"InterfaceEnabled":true}' https://$bmc/redfish/v1/Managers/bmc/EthernetInterfaces/eth0

Expected Results:
IP configuration should persist

@sunharis @wak-google

@prkatti1
Copy link

I think changing the state of the interface should not have any impact on existing network settings.

@swe12345
Copy link
Author

@wak-google Any update on this please

@wak-google
Copy link
Contributor

This is expected, it refreshes the interface after it gets disabled which clears out all the IP info. We don't have a way to read IP information outside of what is configured on the interface.

@swe12345
Copy link
Author

Disabling the interface, we should not loose the IP details right @wak-google??

@wak-google
Copy link
Contributor

We do lose them today, AFAICT it will be difficult for us to model a change to this to preserve the details.

@sunharis
Copy link
Contributor

We do lose them today, AFAICT it will be difficult for us to model a change to this to preserve the details.

Yes. @swe12345 Can this issue be closed? This is working as per the design.

eddiejames pushed a commit to eddiejames/phosphor-networkd that referenced this issue Mar 1, 2024
* Fix compilation issue

This PR is to fix the compilation issue caused by not
declaring a variable.

Reference:
[1] https://sys-openbmc-dev-jenkins.swg-devops.com/job/OpenBMC-Dev/job/build/job/github-private/job/openbmc-build-matrix-x86/label=x86-docker-builder,target=p10bmc/112/console

Signed-off-by: Asmitha Karunanithi <[email protected]>

* Fix compilation issues

This PR fixes compilation issues introduced by the following
PRs:
[1] ibm-openbmc#51

Signed-off-by: Asmitha Karunanithi <[email protected]>

Signed-off-by: Asmitha Karunanithi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants