Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BMC Dump: Refactoring plugin parser infrastructre #5

Open
ojayanth opened this issue Nov 16, 2018 · 2 comments
Open

BMC Dump: Refactoring plugin parser infrastructre #5

ojayanth opened this issue Nov 16, 2018 · 2 comments

Comments

@ojayanth
Copy link
Contributor

BMC Dump Plugin infrastructure in currently placed in phosphor-debug-collector repo.
Proposal is to move plugin into repo specific based on the use case. This design approach will distribute the the plugin ownership to repository maintainers.
Proposed changes: Move install_dreport_user_script(script_path, d): equivalent functionality from phosphor-debug-collector recipe to new class and application can utilize this by inheriting this. this would help the application can control dreport user plugins.
FYI @bradbishop @artemsen

@artemsen
Copy link
Member

The new bbclass looks like an "intermediate solution". I think it would be better to register a dreport's plugins at runtime via D-Bus. This is a more flexible solution and it would obviate the need to use bash commentaries as plugins setup.
For example, we may add some commands to phosphor-debug-collector interface:

AddPlugin(path, runLevel, priority)
RemovePlugin(path)
GetPlugins(runLevel)

and call 'GetPlugins' from dreport script (with busctl) to execute externally registered handlers.
To simplify the dreport interface I would call external plugins with parameters instead of using environment variables, something like this:
extplug dumpPath runLevel

@devenrao
Copy link
Contributor

devenrao commented Apr 2, 2022

probably we can try meson build system to copy the files and create soft links based on the build type setting open-power/ibm/xxx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants