Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agent injector config not compatible with bao executable #7

Open
eremincho opened this issue Aug 2, 2024 · 0 comments
Open

Agent injector config not compatible with bao executable #7

eremincho opened this issue Aug 2, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@eremincho
Copy link

Describe the bug
The Config struct in config.go marshalls the Openbao key as openbao, but the agent command in the bao executable, expects the key to be vault.

To Reproduce
Steps to reproduce the behavior:

  1. Deploy application annotated for openbao-agent injection
  2. The openbao agent init sidecar will fail because the config file is incorrect

Expected behavior
Consistent naming between applications

Additional context
I guess openbao trying to maintain compatibility with vault-k8s for the moment, but how is this change going to be reconciled? At the moment we are patching openbao-k8s to fix this issue. Is there any planned change to either repo to fix this? Looking at the main openbao repo I don't see any issue referencing this.

@eremincho eremincho added the bug Something isn't working label Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant