Use the CSI agent image registry from configuration #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thefinn93
force-pushed
the
csi-agent-image-registry
branch
2 times, most recently
from
1bed2eb
to
b610a94
Compare
cipherboy
reviewed
Sep 9, 2024
Signed-off-by: Finn <[email protected]>
thefinn93
force-pushed
the
csi-agent-image-registry
branch
from
b610a94
to
abacc2f
Compare
Signed-off-by: Finn <[email protected]>
cipherboy
reviewed
Sep 9, 2024
There was a problem hiding this comment.
@thefinn93 Sorry to bother, but while you're here, do you want to update VAULT_ADDR to BAO_ADDR as well?
|
I did want to do that, but the chart defaults to the upstream CSI provider image for the Reading through openbao-csi-driver issue #3 lead me to the conclusion that the upstream CSI provider was used due to there not being a published openbao-csi-provider image. |
cipherboy
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing the agent to fail to start on amd64 because the
docker.io/openbao/openbaoimage seems to only support ARM.I also updated the environment variables that get passed to the bao agent to use
BAO_prefix.