Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hashicorp documentation links from values.yaml #13

Merged

Conversation

Btijmen
Copy link

@Btijmen Btijmen commented Aug 5, 2024

There were 16 references to Hashicorp vault documentation still in comments in the valuesfile. I edited these to point to the respective pages in the OpenBao docs.
This relates to issue #6.

@cipherboy
Copy link
Member

@JanMa @jessebot Do you know if we need the version bump for this that lint reports needing?

image

@JanMa
Copy link
Member

JanMa commented Aug 8, 2024

@JanMa @jessebot Do you know if we need the version bump for this that lint reports needing?

I think it wants to bump the version since there are changes in the values.yaml file. But since this PR only adjusts some comments, I think it's fine if we keep the current version.

@cipherboy cipherboy merged commit ad8307d into openbao:main Aug 8, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants