Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Hashicorp and Vault References #6

Open
naphelps opened this issue May 17, 2024 · 3 comments
Open

Remove Hashicorp and Vault References #6

naphelps opened this issue May 17, 2024 · 3 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@naphelps
Copy link
Member

naphelps commented May 17, 2024

Change references as needed from Hashicorp Vault to OpenBao. Remove as needed Enterprise references.

@jessebot
Copy link

Should we also do the copyright notices? See #4

@jessebot
Copy link

Thanks for your reply in the discussion :)

Updates for this issue specifically, so others are in the know:

After #7 was merged, @naphelps took care of a lot of it (thank you 🙏 ). We still have a number of references to vault specifically in the _helpers.tpl template though. This is important, because typically in helm charts, named templated should reference the application you're deploying, as you can also reference downstream sub-chart templates, so if someone includes our openbao helm chart in their larger stack helm chart, it's important that they can consistantly reference for instance, the openbao.fullname template, which is useful for referencing various resources. Example:

{{- define "vault.fullname" -}}
{{- if .Values.fullnameOverride -}}
{{- .Values.fullnameOverride | trunc 63 | trimSuffix "-" -}}
{{- else -}}
{{- $name := default .Chart.Name .Values.nameOverride -}}
{{- if contains $name .Release.Name -}}
{{- .Release.Name | trunc 63 | trimSuffix "-" -}}
{{- else -}}
{{- printf "%s-%s" .Release.Name $name | trunc 63 | trimSuffix "-" -}}
{{- end -}}
{{- end -}}
{{- end -}}

Since these are all named templates, we'll also need to update locations that reference them, such as:

name: {{ template "vault.fullname" . }}-server-test

I will take care of some of this while tending to #9, but we'll assess again after that. Other than that, we just need to finish up #3 and we should be golden on this issue :)

@jessebot
Copy link

jessebot commented Jun 1, 2024

I got the bulk of this in #11, but I missed a couple of important bits that I'll address in just a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants