Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let me add all the councillors for an authority in one contribution #1178

Closed
equivalentideas opened this issue Jun 20, 2017 · 3 comments
Closed
Assignees

Comments

@equivalentideas
Copy link
Contributor

Currently on the person_contributes_councillor_info branch, people can add information for one councillor at a time.

They should be able to add details for all the councillors for an authority in one contribution.

Extracted from #1160

@equivalentideas
Copy link
Contributor Author

Next step, @equivalentideas write test.

@equivalentideas
Copy link
Contributor Author

Next step, @equivalentideas write test.

I've just changed the existing test in 8db2c84...1456991

This is an interesting bit that we could probably write a few more tests for as we define how it really works, but I this feels like the next most basic step.

As we spoke about last week @hisayohorie I image you might be adding a new CouncillorContribution model or something that connects a set of SuggestedCouncillors to the Contributor.

I think don't worry too much about validations and stuff yet, because we can describe the specific behavior we want in issues and then write tests and then add it. If you have ideas for that, go ahead and make those issues :) Again that form book will have useful advice for that.

@equivalentideas
Copy link
Contributor Author

Since #1192 was merged, you can now make a contribution with as many councillors as you want which solves this issues. 🔨 Great work @hisayohorie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants