Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Councillor info contributor provides their details so the admin can contact them about their contribution and thank them #1177

Closed
equivalentideas opened this issue Jun 20, 2017 · 4 comments
Assignees

Comments

@equivalentideas
Copy link
Contributor

To contact them, we'll need people’s email address. To be able to thank them, recognise their contribution and communicate with them in a nice friendly way, we need their name too.

We should get these details at the end of the process, so they can get straight into adding councillors.

Extracted from #1160

@hisayohorie
Copy link
Contributor

hisayohorie commented Jun 20, 2017

in relation to #1179 and the design principle, I think the information of the user should be optional.
Also, for the user contribution flow, I think it is a nicer/less work experience for user if the form of the suggested councillor and their (optional) user info can be submitted all at once with one click(flow 2 in the chart).
user_contribution_flow

So I'm going in to do:

  1. write a test for
  • user info submission (create new contributor_spec.rb)
  • admin to see the user data (in existing admin_views councillor_contribution_spec.rb)
  1. create contributor_model

For now, let the suggested_councillors_controller handle the contributor data so no contributor_controller ?
3) add the contributor info in the admin suggested councillors page

is this the right direction? @equivalentideas @henare

@hisayohorie
Copy link
Contributor

So the main issues here are:

  1. Does the user information need to be optional or mandatory?

  2. Does the submission of data need to be 1 step or 2 steps?

  3. Does the user information need to be optional or mandatory?
    mirroring to our principle, I think users need to have control of where and when they give up their information. so I still think it needs to be optional.

For 2), After a bit of research, I started to lean toward for 2 steps submission.
1 step submission
pros

  • Less work for users.

cons

  • Presenting optional input with mandatory input may send a mixed message

2 steps submission
pros

  • It is obvious that the user information input is optional by the way it presents itself as a follow-up
  • It makes the input more conversational

cons

  • More work for users

From a bit of research, I am leaning toward 2 steps submissions. It feels to me that there are more pros than cons.
user_contribution_flow_2

@henare
Copy link
Member

henare commented Jun 27, 2017

is this the right direction? @equivalentideas @henare

Hey @hisayohorie, as we've discussed in other channels this is looking good and is all headed in the right direction 👍

Does the submission of data need to be 1 step or 2 steps?

We've all discussed this a bit in another thread. I think I might have disrupted things by suggesting we keep it simple on the 1 page for now. Both @hisayohorie and @equivalentideas have said they think 2 step is the way to go so if we want to change this now then I'm up for that.

@equivalentideas
Copy link
Contributor Author

Sounds good to me, what do you recon @hisayohorie ? If you're into it maybe we should change the title of this issue to be "Councillor info contributor provides their details on a second page after adding councillors so the admin can contact them about their contribution and thank them".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants