Skip to content
This repository has been archived by the owner on Sep 8, 2021. It is now read-only.

Also store copies of the CSVs in this repo for backup purposes #95

Closed
henare opened this issue Jul 13, 2016 · 4 comments
Closed

Also store copies of the CSVs in this repo for backup purposes #95

henare opened this issue Jul 13, 2016 · 4 comments
Assignees

Comments

@henare
Copy link
Member

henare commented Jul 13, 2016

While importing some contributions I just noticed that it was quite hard to spot an unintentional error and fix it using the Sheets revision history. Maybe storing copies of the CSVs we download would help?

@equivalentideas
Copy link
Collaborator

equivalentideas commented Sep 19, 2017

As part of openaustralia/planningalerts#1203 (comment) @hisayohorie and I agreed we need to get the CSV's into the repo. Read more up on that issue about the process we're imaging.

noticed that it was quite hard to spot an unintentional error and fix it using the Sheets revision histor

This should be much easier with git diffs and the ability to git checkout to a specific clean slate.

So we're imaging following the pattern used by EveryPolitician of having a folder for each data folder, a folder for each jurisdiction, and then the csv and json in there. See https://github.com/everypolitician/everypolitician-data/tree/master/data/Australia/Representatives

So we're imaging a directory structure like:

  • data
    • NSW
      • nsw_local_councillors.csv
      • nsw_local_councillor_popolo.csv
    • VIC
      • ...

Steps (separate PRs):

  1. download the CSV files, name them appropriately and put them into the repo (done in Created csv file of local councillor based on state in data folder #124)

  2. add the directory structure and adapt the rake task to work with it

  3. adapt the rake file to target the local CSV file rather than the Google Doc

    • update the docs to explain that you need to edit these files now not the Google Sheet

@equivalentideas
Copy link
Collaborator

I've assigned this to you @hisayohorie post any questions or anything here 😄

@equivalentideas
Copy link
Collaborator

@hisayohorie is doing steps 1. " add the directory structure and adapt the rake task to work with it" and 3. "adapt the rake file to target the local CSV file rather than the Google Doc" in one go in #125

@equivalentideas
Copy link
Collaborator

This is now done in #125

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants