Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify example for 02-containerized-docker-engine #42

Open
ALanguillaume opened this issue Jun 3, 2024 · 2 comments
Open

Simplify example for 02-containerized-docker-engine #42

ALanguillaume opened this issue Jun 3, 2024 · 2 comments
Labels
question Further information is requested

Comments

@ALanguillaume
Copy link

Hoi @openanalytics !

Thanks for this great tool.

I was skimming through the documentation for 02-containerized-docker-engine and I am wondering if the example could be simplified or not.

I tend to use directly your openanalytics/shinyproxy image and mount the application.yml as a volume in the docker run or compose command as such:

docker run \
-v /var/run/docker.sock:/var/run/docker.sock:ro \
-v ./application.yml:/opt/shinyproxy/application.yml \
--group-add $(getent group docker | cut -d: -f3) \
--net sp-example-net \
-p 8080:8080 \
openanalytics/shinyproxy:3.1.0

Any reason not to implement this as the example ?

Is it only for didactic reasons or am I missing nothing ?

@LEDfan LEDfan added the question Further information is requested label Jun 13, 2024
@LEDfan
Copy link
Member

LEDfan commented Jun 13, 2024

Hi, thanks for opening this issue. There is no specific reason for this, but I guess the original idea was to demonstrate how people could customize the image. Since mounting the config file reduces the number of steps, I'll update the example to use this approach.

@ALanguillaume
Copy link
Author

Happy days !
Thanks for your reply

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants