Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rapidquilt changes symlink to file copy when refreshing patch #9

Open
hramrach opened this issue Dec 19, 2019 · 2 comments
Open

rapidquilt changes symlink to file copy when refreshing patch #9

hramrach opened this issue Dec 19, 2019 · 2 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@hramrach
Copy link
Contributor

  • add patch adding symlink to series.conf
  • sequence with rapidquilt until the patch
  • push and refresh patch

Expected: patch still adds symlink
Actual: patch now adds copy of the linked file

@mkubecek
Copy link

The primary problem IMHO is that rapidquilt doesn't really understand the syntax and doesn't apply such patch correctly. If you run scripts/sequence-patch.sh --rapid on current SLE15-SP2 or openSUSE-15.2 branch, you get

> ls -l tools/testing/selftests/powerpc/copyloops/
---------- 1 mike users   50 úno 17 08:53 memcpy_mcsafe_64.S

where the contents of the file created is what was supposed to be the link target:

../../../../../arch/powerpc/lib/memcpy_mcsafe_64.S

(i.e. the path, not the contents of the target file).

@hramrach
Copy link
Contributor Author

@ptesarik ptesarik self-assigned this Dec 4, 2020
@ptesarik ptesarik added the good first issue Good for newcomers label Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants