Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hunks after unusual long hunk are not applied #25

Open
olafhering opened this issue Oct 14, 2022 · 2 comments
Open

hunks after unusual long hunk are not applied #25

olafhering opened this issue Oct 14, 2022 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@olafhering
Copy link

The attached patch
msft-hv-2510-PCI-hv-Make-the-code-arch-neutral-by-adding-arch-spe.patch.gz
is not fully applied to openSUSE/kernel-source@c4cee83.

The hunk up to hv_msi_irq_chip will be applied. The following hunks, starting from hv_pcie_init_irq_domain are not applied anymore.

This might be caused by the fact that hv_msi_domain_ops_get_hwirq was inserted into the middle of the original torvalds/linux@831c1ae, just to avoid further backports. But since the hunk is valid, it is not obvious why it would cause issues.

@olafhering
Copy link
Author

It turned out, that long hunk had an extra ^ $ at the end. Apparently all tools silently tolerated this.

@ptesarik ptesarik self-assigned this Oct 21, 2022
@ptesarik ptesarik added the bug Something isn't working label Dec 2, 2022
@ptesarik
Copy link
Contributor

ptesarik commented Dec 2, 2022

Yeah, I can recall that I had a weird feeling about the handling of “noise lines” between hunks and I have even found a TODO item to re-check it against GNU patch behaviour. So, now is the time, I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants