diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 3b48cdaed4..0d79098f0a 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,12 +1,12 @@ # This configuration was generated by # `rubocop --auto-gen-config` -# on 2024-06-07 15:38:52 UTC using RuboCop version 1.64.1. +# on 2024-12-02 11:47:52 UTC using RuboCop version 1.66.1. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new # versions of RuboCop, may require this file to be generated again. -# Offense count: 4 +# Offense count: 5 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: TreatCommentsAsGroupSeparators, ConsiderPunctuation, Include. # Include: **/*.gemfile, **/Gemfile, **/gems.rb @@ -133,7 +133,7 @@ Layout/EmptyLineAfterMagicComment: Exclude: - 'spec/models/conference_spec.rb' -# Offense count: 100 +# Offense count: 101 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: empty_lines, no_empty_lines @@ -526,7 +526,7 @@ Metrics/BlockLength: Max: 202 # Offense count: 1 -# Configuration parameters: CountBlocks. +# Configuration parameters: CountBlocks, CountModifierForms. Metrics/BlockNesting: Max: 4 @@ -645,17 +645,12 @@ RSpec/AnyInstance: # Offense count: 5 # This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: AutoCorrect. RSpec/BeEmpty: Exclude: - 'spec/controllers/conference_registration_controller_spec.rb' - 'spec/models/conference_spec.rb' -# Offense count: 143 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: EnabledMethods. -RSpec/Capybara/FeatureMethods: - Enabled: false - # Offense count: 302 # Configuration parameters: Prefixes, AllowedPatterns. # Prefixes: when, with, without @@ -779,21 +774,6 @@ RSpec/ExpectChange: - 'spec/models/event_spec.rb' - 'spec/models/user_spec.rb' -# Offense count: 9 -# Configuration parameters: Include, CustomTransform, IgnoreMethods, SpecSuffixOnly. -# Include: **/*_spec*rb*, **/spec/**/* -RSpec/FilePath: - Exclude: - - 'spec/controllers/conference_registration_controller_spec.rb' - - 'spec/controllers/physical_ticket_controller_spec.rb' - - 'spec/features/email_spec.rb' - - 'spec/features/omniauth_spec.rb' - - 'spec/features/proposals_spec.rb' - - 'spec/features/ticket_purchases_spec.rb' - - 'spec/features/venues_spec.rb' - - 'spec/models/comment_spec.rb' - - 'spec/models/openid.rb' - # Offense count: 166 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. @@ -1003,6 +983,7 @@ RSpec/ReturnFromStub: # Offense count: 18 # This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: AutoCorrect. RSpec/ScatteredLet: Exclude: - 'spec/ability/ability_spec.rb' @@ -1010,6 +991,7 @@ RSpec/ScatteredLet: # Offense count: 2 # This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: AutoCorrect. RSpec/ScatteredSetup: Exclude: - 'spec/models/payment_spec.rb' diff --git a/Gemfile b/Gemfile index 0db8e5fa78..fd24ba87a1 100644 --- a/Gemfile +++ b/Gemfile @@ -197,6 +197,8 @@ group :development do gem 'rubocop', require: false gem 'rubocop-rspec', require: false gem 'rubocop-rails', require: false + gem 'rubocop-rspec_rails', require: false + gem 'rubocop-factory_bot', require: false gem 'rubocop-capybara', require: false gem 'rubocop-performance', require: false gem 'haml_lint' diff --git a/Gemfile.lock b/Gemfile.lock index acbb799a98..e128c5863e 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -495,13 +495,11 @@ GEM rack (>= 1.1) rubocop (>= 1.33.0, < 2.0) rubocop-ast (>= 1.31.1, < 2.0) - rubocop-rspec (2.29.2) - rubocop (~> 1.40) - rubocop-capybara (~> 2.17) - rubocop-factory_bot (~> 2.22) - rubocop-rspec_rails (~> 2.28) - rubocop-rspec_rails (2.28.3) - rubocop (~> 1.40) + rubocop-rspec (3.2.0) + rubocop (~> 1.61) + rubocop-rspec_rails (2.30.0) + rubocop (~> 1.61) + rubocop-rspec (~> 3, >= 3.0.1) ruby-oembed (0.17.0) ruby-openid (2.9.2) ruby-progressbar (1.13.0) @@ -686,9 +684,11 @@ DEPENDENCIES rspec-rails rubocop rubocop-capybara + rubocop-factory_bot rubocop-performance rubocop-rails rubocop-rspec + rubocop-rspec_rails ruby-oembed sass-rails (>= 4.0.2) selectize-rails