Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give "completeness" of genotyping file and file format. #358

Closed
gedankenstuecke opened this issue May 24, 2017 · 4 comments
Closed

Give "completeness" of genotyping file and file format. #358

gedankenstuecke opened this issue May 24, 2017 · 4 comments

Comments

@gedankenstuecke
Copy link
Member

Further suggestions that came via email:

  1. It would also be useful to have a column that indicates if the genotype is complete or partial. There are some users that have uploaded only chromosome 1 or Y.
  2. Perhaps also a column indicating in which format it is. There are some users that uploaded pdf (scan) of the paper genotype document.

Both would be cool. For 2) I think we'd just need to check the format during upload and reject everything where the type is not text or zip. 1) could be more tricky, as in principle there's no "completeness" due to the varying nature of the input data. But could at least count how many chromosome are represented?

@tsujigiri
Copy link
Collaborator

Don't we have the format in the database already? And if we have other formats than the ones we can handle, we should probably delete them or mark them as invalid, when the parsing fails.

@gedankenstuecke
Copy link
Member Author

gedankenstuecke commented May 25, 2017 via email

@gedankenstuecke
Copy link
Member Author

After sleeping over this: Don't think it makes much sense for us to check how complete a genotyping file is, i.e. the tipsy tests have only 5 SNPs or so they test, still they are complete in the sense that they tested all what they wanted to test.

The format problem should rather be tackled during the upload -> sometimes our parsers are too lenient in accepting data. Should be it's own issue, see #371

@philippbayer
Copy link
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants