-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Give "completeness" of genotyping file and file format. #358
Comments
Don't we have the format in the database already? And if we have other formats than the ones we can handle, we should probably delete them or mark them as invalid, when the parsing fails. |
if we have other formats than the ones we can handle, we should probably delete them or mark them as invalid, when the parsing fails.
Yes, that's what I tried to say. Our parsing routines seem to be too eager to accept data right now. For the files we already have we can check which ones don't fit. 👍
|
After sleeping over this: Don't think it makes much sense for us to check how complete a genotyping file is, i.e. the tipsy tests have only 5 SNPs or so they test, still they are complete in the sense that they tested all what they wanted to test. The format problem should rather be tackled during the upload -> sometimes our parsers are too lenient in accepting data. Should be it's own issue, see #371 |
👍 |
Further suggestions that came via email:
Both would be cool. For 2) I think we'd just need to check the format during upload and reject everything where the type is not text or zip. 1) could be more tricky, as in principle there's no "completeness" due to the varying nature of the input data. But could at least count how many chromosome are represented?
The text was updated successfully, but these errors were encountered: