From 0cae357f9b10492a0769d2b866da6d0377e58692 Mon Sep 17 00:00:00 2001 From: Axel Huebl Date: Thu, 26 Oct 2023 11:59:34 -0700 Subject: [PATCH] BP4 Empty Skip: Inline Comment In the original fix, I forgot to link the issue and to mention that only BP4 is affected. --- .../openpmd_timeseries/data_reader/io_reader/utilities.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/openpmd_viewer/openpmd_timeseries/data_reader/io_reader/utilities.py b/openpmd_viewer/openpmd_timeseries/data_reader/io_reader/utilities.py index d849e39..8c5c04f 100644 --- a/openpmd_viewer/openpmd_timeseries/data_reader/io_reader/utilities.py +++ b/openpmd_viewer/openpmd_timeseries/data_reader/io_reader/utilities.py @@ -72,8 +72,8 @@ def get_data(series, record_component, i_slice=None, pos_slice=None, for chunk in chunks: chunk_slice = chunk_to_slice(chunk) - # skip empty slices - # https://github.com/ornladios/ADIOS2 + # skip empty slices: issue for BP4 only + # https://github.com/ornladios/ADIOS2/issues/3459 volume = 1 for csl in chunk_slice: volume *= csl.stop - csl.start @@ -113,8 +113,8 @@ def get_data(series, record_component, i_slice=None, pos_slice=None, s_target = [] # starts and stops in sliced array chunk_slice = chunk_to_slice(chunk) - # skip empty slices - # https://github.com/ornladios/ADIOS2 + # skip empty slices: issue for BP4 only + # https://github.com/ornladios/ADIOS2/issues/3459 volume = 1 for csl in chunk_slice: volume *= csl.stop - csl.start