fix #2486 : updated home activity onResume logic to solve the profile photo bug #2494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NiranjanNlc
changed the title
|
you are changing system theme . Does it work after changing the theme from inside of the app ? |
Yeah , i have updated the screen recorder video of description and added the commit . @PratyushSingh07 Please review and provide some suggestion. |
NiranjanNlc
changed the title
NiranjanNlc
changed the title
|
There is a similar bug in Profile photo of Navigation Drawer. Can you check that also @NiranjanNlc |
yeah i had found it , since this pull request solved for both cases , so did not think of raising next issues . |
NiranjanNlc
force-pushed
the
configureUiMode
branch
from
4033eae
to
1f01942
Compare
NiranjanNlc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2486
Profile photo clearly visible while changing between dark and light mode .
UimodeChangePreview.mp4
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
AndroidStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.