Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Feat: Implement Shimmer while user details are being loaded #2443

Closed
wants to merge 4 commits into from

Conversation

kmanikanta335
Copy link
Contributor

Fixes #2412

Screenshots of UI changes.

2214.mp4
shimmerEffect.mp4

Please make sure these boxes are checked before submitting your pull request - thanks!

  • ✅ Apply the AndroidStyle.xml style template to your code in Android Studio.

  • ✅ Run the unit tests with ./gradlew check to make sure you didn't break anything

  • ✅ If you have multiple commits please combine them into one commit by squashing them.

@kmanikanta335
Copy link
Contributor Author

@PratyushSingh07 pls review it

Copy link
Collaborator

@PratyushSingh07 PratyushSingh07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also make sure to follow the commit guidelines

app/build.gradle Outdated Show resolved Hide resolved
Copy link
Collaborator

@PratyushSingh07 PratyushSingh07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PratyushSingh07
Copy link
Collaborator

make sure to change the commit message @kmanikanta335

@kmanikanta335
Copy link
Contributor Author

@PratyushSingh07 what should I change it to

@PratyushSingh07
Copy link
Collaborator

@PratyushSingh07 what should I change it to

just follow the guidelines

@kmanikanta335
Copy link
Contributor Author

@PratyushSingh07 when will it gets merged

@PratyushSingh07
Copy link
Collaborator

@PratyushSingh07 when will it gets merged

You still haven't followed the commit guidelines. It will be merged only after the admins approval

Feat openMF#2412: Implement Shimmer while user details are being loaded

Feat openMF#2412: Implement Shimmer while user details are being loaded

Feat openMF#2412: Implement Shimmer while user details are being loaded

Feat openMF#2412: Implement Shimmer while user details are being loaded
@kmanikanta335
Copy link
Contributor Author

@PratyushSingh07 i hope now its fine

@therajanmaurya
Copy link
Member

Please resolve the conflicts.

@kmanikanta335
Copy link
Contributor Author

@therajanmaurya i hope now it fine

Copy link
Collaborator

@PratyushSingh07 PratyushSingh07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format your code with ctrl+shift+L if you haven't already. Also I will be converting this PR to draft . You can make it ready for review after you have implemented the changes that i requested

app/build.gradle Outdated Show resolved Hide resolved
@PratyushSingh07 PratyushSingh07 marked this pull request as draft January 2, 2024 16:27
@kmanikanta335 kmanikanta335 marked this pull request as ready for review January 2, 2024 18:33
@PratyushSingh07
Copy link
Collaborator

PratyushSingh07 commented Jan 2, 2024

@kmanikanta335 squash your commits and make sure that your final commit follow contribution guidelines . I am again converting it to draft

@PratyushSingh07 PratyushSingh07 marked this pull request as draft January 2, 2024 19:31
@therajanmaurya therajanmaurya marked this pull request as ready for review January 28, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Implement Shimmer while user details are being loaded
3 participants