Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove hardcoded string from the project. #223

Open
ivary43 opened this issue Apr 2, 2018 · 4 comments
Open

remove hardcoded string from the project. #223

ivary43 opened this issue Apr 2, 2018 · 4 comments

Comments

@ivary43
Copy link

ivary43 commented Apr 2, 2018

Summary:

In many places, hardcoded string is used instead of adding them to string resources and then using from there.
@ivary43
Copy link
Author

ivary43 commented Apr 2, 2018

@therajanmaurya I would like to work on this issue.

@RajaVamsi11
Copy link

@therajanmaurya @ivary43 I would like to work on this issue?

@ivary43
Copy link
Author

ivary43 commented Jan 18, 2019

@RajaVamsi11 go ahead.

@abhijitramesh abhijitramesh mentioned this issue Jan 20, 2019
Closed
3 tasks
@RajaVamsi11
Copy link

@ivary43 There are like 135 hardcoded strings in java files. Take a look.
ScreenShot
screenshot from 2019-01-20 15-51-26
I am going to add all those in strings.xml and use them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ivary43 @RajaVamsi11