Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make convert_loops_to_sites more strict? #9

Open
gfudenberg opened this issue Oct 13, 2023 · 1 comment
Open

make convert_loops_to_sites more strict? #9

gfudenberg opened this issue Oct 13, 2023 · 1 comment
Assignees
Labels

Comments

@gfudenberg
Copy link
Member

is there a reason for allowing two lists to be passed? cc @golobor

convert_loops_to_sites also has a failure mode for n=2. My previous solution was not very elegant...

if specifyVerticalArray==True:
. Perhaps this aspect of autodetection can also just be disabled?

@gfudenberg
Copy link
Member Author

how bad would it be to assume that loops are always numpy arrays? (and deprecate lists of tuples)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants