Skip to content
This repository has been archived by the owner on Oct 23, 2024. It is now read-only.

Failed in adding output to video-engine #1391

Open
Phillipip opened this issue Jul 16, 2024 · 3 comments
Open

Failed in adding output to video-engine #1391

Phillipip opened this issue Jul 16, 2024 · 3 comments

Comments

@Phillipip
Copy link

In Europe, a frame rate of 25 is common. However, if I try to change the room's frame rate to 25 and add it to the list of allowed frames, I get the error message when subscribing to the stream: Failed in adding output to video-engine. Are there any ideas about this?

@starwarfan
Copy link
Collaborator

If you are using software compositor,

diff --git a/source/agent/video/videoMixer/SoftVideoCompositor.cpp b/source/agent/video/videoMixer/SoftVideoCompositor.cpp
index 0038b594..2ed8a48e 100644
--- a/source/agent/video/videoMixer/SoftVideoCompositor.cpp
+++ b/source/agent/video/videoMixer/SoftVideoCompositor.cpp
@@ -612,9 +612,10 @@ SoftVideoCompositor::SoftVideoCompositor(uint32_t maxInput, VideoSize rootSize,
 
     m_avatarManager.reset(new AvatarManager(maxInput));
 
-    m_generators.resize(2);
+    m_generators.resize(3);
     m_generators[0].reset(new SoftFrameGenerator(this, rootSize, bgColor, crop, 60, 15));
     m_generators[1].reset(new SoftFrameGenerator(this, rootSize, bgColor, crop, 48, 6));
+    m_generators[2].reset(new SoftFrameGenerator(this, rootSize, bgColor, crop, 50, 25));
 }
 
 SoftVideoCompositor::~SoftVideoCompositor()

scripts/build.js -t video-mixer-sw
repack video agent

If you're using MsdkVideoCompositor, make similar changes as above.

@Phillipip
Copy link
Author

Thank you for the hint. Wouldn't it be better if the frame and keyframe rate as passed by the room could be used correctly?

@starwarfan
Copy link
Collaborator

Because there was no such requirement before, and various settings will increase testing overhead.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants