update backpressure #231
Closed
update backpressure #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… dev_connection * 'dev_connection' of github.com:open-web3-stack/boka: try ubuntu-24.04 try different runner image
xlc
reviewed
Nov 25, 2024
xlc
reviewed
Nov 26, 2024
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
xlc
reviewed
Dec 4, 2024
| @@ -126,7 +129,63 @@ final class Stream<Handler: StreamHandler>: Sendable, StreamProtocol { | |||
| } | |||
| if !channel.syncSend(data) { | |||
| logger.warning("stream \(id) is full") | |||
| // TODO: backpressure handling | |||
| receiveData.write { receiveData in | |||
There was a problem hiding this comment.
the receive order can still be wrong (and need some tests to verify this case:
- receive data1, unable to send to append to
receivedData - receive data2, actually able to send, and sent it
- after sleep, sending data1
now the receiver received data2, and data1, which is wrong
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.