Add validation for method invocation types

Report when

* invokevirtual calls an interface method
* invokeinterface calls a class method
* non-constructor invokespecial calls a method on a class outside of
caller's hierarchy

core/src/main/kotlin/com/toasttab/expediter/Expediter.kt

@@ -35,6 +35,7 @@ import com.toasttab.expediter.types.members
 import protokt.v1.toasttab.expediter.v1.AccessDeclaration
 import protokt.v1.toasttab.expediter.v1.MemberDescriptor
 import protokt.v1.toasttab.expediter.v1.TypeExtensibility
+import protokt.v1.toasttab.expediter.v1.TypeFlavor
 
 class Expediter(
     private val ignore: Ignore,
@@ -167,6 +168,12 @@ class Expediter(
                         Issue.AccessStaticMemberNonStatically(type.name, resolvedAccess)
                     } else if (member.member.declaration == AccessDeclaration.INSTANCE && access.accessType.isStatic()) {
                         Issue.AccessInstanceMemberStatically(type.name, resolvedAccess)
+                    } else if (access.accessType == MethodAccessType.INTERFACE && chain.type.descriptor.flavor == TypeFlavor.CLASS) {
+                        Issue.InterfaceCallToClass(type.name, resolvedAccess)
+                    } else if (access.accessType == MethodAccessType.VIRTUAL && chain.type.descriptor.flavor == TypeFlavor.INTERFACE) {
+                        Issue.VirtualCallToInterface(type.name, resolvedAccess)
+                    } else if (access.accessType == MethodAccessType.SPECIAL && !access.ref.isConstructor() && hierarchy is ResolvedTypeHierarchy.CompleteTypeHierarchy && !hierarchy.allTypes.contains(chain.type)) {
+                        Issue.SpecialCallOutOfHierarchy(type.name, resolvedAccess)
                     } else if (!AccessCheck.allowedAccess(hierarchy, chain, member.member, member.declaringType)) {
                         Issue.AccessInaccessibleMember(type.name, resolvedAccess)
                     } else {

model/src/main/kotlin/com/toasttab/expediter/issue/Issue.kt

@@ -93,6 +93,27 @@ sealed interface Issue {
         override fun toString() = "$caller accesses inaccessible $member"
     }
 
+    @Serializable
+    @SerialName("virtual-call-to-interface")
+    data class VirtualCallToInterface(override val caller: String, override val member: MemberAccess) : Issue, WithMemberAccess {
+        override val target: String get() = member.targetType
+        override fun toString() = "$caller accesses interface method $member virtually"
+    }
+
+    @Serializable
+    @SerialName("interface-call-to-class")
+    data class InterfaceCallToClass(override val caller: String, override val member: MemberAccess) : Issue, WithMemberAccess {
+        override val target: String get() = member.targetType
+        override fun toString() = "$caller accesses class method $member interfacely"
+    }
+
+    @Serializable
+    @SerialName("special-call-out-of-hierarchy")
+    data class SpecialCallOutOfHierarchy(override val caller: String, override val member: MemberAccess) : Issue, WithMemberAccess {
+        override val target: String get() = member.targetType
+        override fun toString() = "$caller makes a special call to non-contructor $member which is not in its hierarchy"
+    }
+
     @Serializable
     data class UnknownIssue internal constructor(
         val type: String,

tests/lib1/src/testFixtures/java/com/toasttab/expediter/test/WasClass.java

@@ -0,0 +1,5 @@
+package com.toasttab.expediter.test;
+
+public class WasClass {
+    public void foo() { }
+}

tests/lib1/src/testFixtures/java/com/toasttab/expediter/test/WasInterface.java

@@ -0,0 +1,5 @@
+package com.toasttab.expediter.test;
+
+public interface WasInterface {
+    void foo();
+}

tests/lib2/src/testFixtures/java/com/toasttab/expediter/test/WasClass.java

@@ -0,0 +1,5 @@
+package com.toasttab.expediter.test;
+
+public interface WasClass {
+    void foo();
+}

tests/lib2/src/testFixtures/java/com/toasttab/expediter/test/WasInterface.java

@@ -0,0 +1,5 @@
+package com.toasttab.expediter.test;
+
+public class WasInterface {
+    void foo() { }
+}

tests/src/test/kotlin/com/toasttab/expediter/test/ExpediterIntegrationTest.kt

@@ -154,6 +154,26 @@ class ExpediterIntegrationTest {
                 )
             ),
 
+            Issue.VirtualCallToInterface(
+                "com/toasttab/expediter/test/caller/Caller",
+                MemberAccess.MethodAccess(
+                    "com/toasttab/expediter/test/WasClass",
+                    "com/toasttab/expediter/test/WasClass",
+                    MemberSymbolicReference("foo", "()V"),
+                    MethodAccessType.VIRTUAL
+                )
+            ),
+
+            Issue.InterfaceCallToClass(
+                "com/toasttab/expediter/test/caller/Caller",
+                MemberAccess.MethodAccess(
+                    "com/toasttab/expediter/test/WasInterface",
+                    "com/toasttab/expediter/test/WasInterface",
+                    MemberSymbolicReference("foo", "()V"),
+                    MethodAccessType.INTERFACE
+                )
+            ),
+
             Issue.MissingApplicationSuperType(
                 "com/toasttab/expediter/test/Foo",
                 setOf("com/toasttab/expediter/test/BaseFoo")
@@ -225,6 +245,8 @@ class ExpediterIntegrationTest {
             "com/toasttab/expediter/test/caller/Caller accesses inaccessible com/toasttab/expediter/test/Bar.bar(F)V (via com/toasttab/expediter/test/Baz)",
             "com/toasttab/expediter/test/caller/Caller accesses inaccessible com/toasttab/expediter/test/Bar.bar(I)V",
             "com/toasttab/expediter/test/caller/Caller accesses inaccessible com/toasttab/expediter/test/Bar.bar(J)V",
+            "com/toasttab/expediter/test/caller/Caller accesses interface method com/toasttab/expediter/test/WasClass.foo()V virtually",
+            "com/toasttab/expediter/test/caller/Caller accesses class method com/toasttab/expediter/test/WasInterface.foo()V interfacely",
             "com/toasttab/expediter/test/Foo extends missing type com/toasttab/expediter/test/BaseFoo",
             "duplicate class com/toasttab/expediter/test/Dupe in [testFixtures, lib2-test-fixtures.jar]"
         )

tests/src/testFixtures/java/com/toasttab/expediter/test/caller/Caller.java

@@ -23,6 +23,8 @@
 import com.toasttab.expediter.test.Lambda;
 import com.toasttab.expediter.test.ParamParam;
 import com.toasttab.expediter.test.Var;
+import com.toasttab.expediter.test.WasClass;
+import com.toasttab.expediter.test.WasInterface;
 
 import java.lang.invoke.MethodHandle;
 import java.lang.invoke.MethodHandles;
@@ -112,4 +114,12 @@ boolean missingTypeInstanceof(Object o) {
     void superMethodMoved() {
         super.supersuper();
     }
+
+    void interfaceToClass(WasInterface o) {
+        o.foo();
+    }
+
+    void virtualToInterface(WasClass o) {
+        o.foo();
+    }
 }